X Tutup
The Wayback Machine - https://web.archive.org/web/20220126035317/https://github.com/facebook/react/pull/22952
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vite plugin for React Server Components #22952

Open
wants to merge 15 commits into
base: main
Choose a base branch
from
Open

Conversation

@frandiox
Copy link
Contributor

@frandiox frandiox commented Dec 14, 2021

Summary

Hi! This PR implements a Vite plugin for React Server Components. This is the approach we are currently exploring at @shopify/hydrogen and is extracted from here. Hydrogen is right now using a custom implementation of RSC but we would like to switch to the official implementation as soon as possible and make it work with SSR. This PR is meant to serve as a discussion to see what would be the best approach and some trade-offs.

Assumptions and constraints

As far as I understand, React 18 experimental supports server components by importing a "module reference" instead of actual client components in a Node process. This is done by using Node's native --conditions and registers/loaders. However, in order to do SSR we need the "real" client components in the process, not these module references. Therefore, it sounds like these two features are right now mutually exclusive unless we create 2 bundles or 2 different Node environments.

On the other hand, Vite typically runs on only 1 process and its philosophy is basically no-bundles in development to speed things up. Plus, the main build target for Hydrogen is Oxygen and Cloudflare Workers, which can't be run as 2 processes and don't have Node's native --conditions or registers.

Proposed approach

Instead of relying on Node flags or registers, the Vite plugin in this PR is wrapping every client component in a proxy that merges the component itself with its module reference in the same object. The React SSR renderer will treat this resulting object as a normal component whereas the RSC renderer will use it as a module reference. This way, it can run RSC and SSR in the same process without requiring multiple bundles or Node flags.

Implementation details and clarifications

  • The ClientProxy is basically wrapping components in ForwardRefs. The only reason to do this is so that the whole thing evaluates to typeof component === 'object' (instead of 'function') in order to reach this line in the RSC renderer. This could be simplified if we are willing to change the attemptResolveElement logic a bit.
  • This does not use any manifest or "bundler config" because it relies on Vite's glob imports (a manifest could be added later to reveal dependencies earlier). These imports are injected around the __INJECTED_CLIENT_IMPORTERS__ object.

Apart from implementation details that can be fixed or improved, would this be a valid approach in your opinion? Or would it be valid without the SSR piece (i.e. only RSC without merging module references and components)? Any other ideas that work with the constraints mentioned above?

It would be interesting to generate the RSC flight response at the same time of doing SSR since tree nodes are both components and module references. However, I don't think there's any way to hook into that process right now.

There's a demo project using this implementation here (only RSC, not SSR): GitHub source | Stackblitz live demo

@sizebot
Copy link

@sizebot sizebot commented Dec 14, 2021

Comparing: f2a59df...d6a895a

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js = 129.54 kB 129.54 kB = 41.51 kB 41.51 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js = 134.68 kB 134.68 kB = 43.02 kB 43.02 kB
facebook-www/ReactDOM-prod.classic.js = 427.78 kB 427.78 kB = 78.55 kB 78.55 kB
facebook-www/ReactDOM-prod.modern.js = 417.47 kB 417.47 kB = 77.07 kB 77.07 kB
facebook-www/ReactDOMForked-prod.classic.js = 427.78 kB 427.78 kB = 78.55 kB 78.55 kB
oss-experimental/react-server-dom-vite/cjs/react-server-dom-vite-plugin.js +∞% 0.00 kB 5.49 kB +∞% 0.00 kB 2.21 kB
oss-experimental/react-server-dom-vite/cjs/react-server-dom-vite-writer.browser.development.server.js +∞% 0.00 kB 28.03 kB +∞% 0.00 kB 7.65 kB
oss-experimental/react-server-dom-vite/cjs/react-server-dom-vite-writer.browser.production.min.server.js +∞% 0.00 kB 7.56 kB +∞% 0.00 kB 3.03 kB
oss-experimental/react-server-dom-vite/cjs/react-server-dom-vite-writer.node.development.server.js +∞% 0.00 kB 28.20 kB +∞% 0.00 kB 7.56 kB
oss-experimental/react-server-dom-vite/cjs/react-server-dom-vite-writer.node.production.min.server.js +∞% 0.00 kB 7.75 kB +∞% 0.00 kB 3.06 kB
oss-experimental/react-server-dom-vite/cjs/react-server-dom-vite.development.js +∞% 0.00 kB 16.67 kB +∞% 0.00 kB 4.90 kB
oss-experimental/react-server-dom-vite/cjs/react-server-dom-vite.production.min.js +∞% 0.00 kB 3.87 kB +∞% 0.00 kB 1.74 kB
oss-experimental/react-server-dom-vite/esm/react-server-dom-vite-client-proxy.js +∞% 0.00 kB 2.16 kB +∞% 0.00 kB 0.94 kB
oss-experimental/react-server-dom-vite/esm/react-server-dom-vite-plugin.js +∞% 0.00 kB 5.45 kB +∞% 0.00 kB 2.19 kB
oss-experimental/react-server-dom-vite/esm/react-server-dom-vite-writer.browser.server.js +∞% 0.00 kB 27.93 kB +∞% 0.00 kB 7.60 kB
oss-experimental/react-server-dom-vite/esm/react-server-dom-vite-writer.node.server.js +∞% 0.00 kB 28.11 kB +∞% 0.00 kB 7.51 kB
oss-experimental/react-server-dom-vite/esm/react-server-dom-vite.js +∞% 0.00 kB 16.49 kB +∞% 0.00 kB 4.84 kB
oss-experimental/react-server-dom-vite/index.js +∞% 0.00 kB 0.22 kB +∞% 0.00 kB 0.16 kB
oss-experimental/react-server-dom-vite/plugin.js +∞% 0.00 kB 0.08 kB +∞% 0.00 kB 0.10 kB
oss-experimental/react-server-dom-vite/umd/react-server-dom-vite-writer.browser.development.server.js +∞% 0.00 kB 29.74 kB +∞% 0.00 kB 7.80 kB
oss-experimental/react-server-dom-vite/umd/react-server-dom-vite-writer.browser.production.min.server.js +∞% 0.00 kB 7.78 kB +∞% 0.00 kB 3.13 kB
oss-experimental/react-server-dom-vite/umd/react-server-dom-vite.development.js +∞% 0.00 kB 17.91 kB +∞% 0.00 kB 5.02 kB
oss-experimental/react-server-dom-vite/umd/react-server-dom-vite.production.min.js +∞% 0.00 kB 4.07 kB +∞% 0.00 kB 1.84 kB
oss-experimental/react-server-dom-vite/writer.browser.server.js +∞% 0.00 kB 0.27 kB +∞% 0.00 kB 0.17 kB
oss-experimental/react-server-dom-vite/writer.node.server.js +∞% 0.00 kB 0.26 kB +∞% 0.00 kB 0.17 kB
oss-stable-semver/react-server-dom-vite/cjs/react-server-dom-vite-plugin.js +∞% 0.00 kB 5.49 kB +∞% 0.00 kB 2.21 kB
oss-stable-semver/react-server-dom-vite/cjs/react-server-dom-vite-writer.browser.development.server.js +∞% 0.00 kB 28.03 kB +∞% 0.00 kB 7.65 kB
oss-stable-semver/react-server-dom-vite/cjs/react-server-dom-vite-writer.browser.production.min.server.js +∞% 0.00 kB 7.56 kB +∞% 0.00 kB 3.03 kB
oss-stable-semver/react-server-dom-vite/cjs/react-server-dom-vite-writer.node.development.server.js +∞% 0.00 kB 28.20 kB +∞% 0.00 kB 7.56 kB
oss-stable-semver/react-server-dom-vite/cjs/react-server-dom-vite-writer.node.production.min.server.js +∞% 0.00 kB 7.75 kB +∞% 0.00 kB 3.06 kB
oss-stable-semver/react-server-dom-vite/cjs/react-server-dom-vite.development.js +∞% 0.00 kB 16.67 kB +∞% 0.00 kB 4.90 kB
oss-stable-semver/react-server-dom-vite/cjs/react-server-dom-vite.production.min.js +∞% 0.00 kB 3.87 kB +∞% 0.00 kB 1.74 kB
oss-stable-semver/react-server-dom-vite/esm/react-server-dom-vite-client-proxy.js +∞% 0.00 kB 2.16 kB +∞% 0.00 kB 0.94 kB
oss-stable-semver/react-server-dom-vite/esm/react-server-dom-vite-plugin.js +∞% 0.00 kB 5.45 kB +∞% 0.00 kB 2.19 kB
oss-stable-semver/react-server-dom-vite/esm/react-server-dom-vite-writer.browser.server.js +∞% 0.00 kB 27.93 kB +∞% 0.00 kB 7.60 kB
oss-stable-semver/react-server-dom-vite/esm/react-server-dom-vite-writer.node.server.js +∞% 0.00 kB 28.11 kB +∞% 0.00 kB 7.51 kB
oss-stable-semver/react-server-dom-vite/esm/react-server-dom-vite.js +∞% 0.00 kB 16.49 kB +∞% 0.00 kB 4.84 kB
oss-stable-semver/react-server-dom-vite/index.js +∞% 0.00 kB 0.22 kB +∞% 0.00 kB 0.16 kB
oss-stable-semver/react-server-dom-vite/plugin.js +∞% 0.00 kB 0.08 kB +∞% 0.00 kB 0.10 kB
oss-stable-semver/react-server-dom-vite/umd/react-server-dom-vite-writer.browser.development.server.js +∞% 0.00 kB 29.74 kB +∞% 0.00 kB 7.80 kB
oss-stable-semver/react-server-dom-vite/umd/react-server-dom-vite-writer.browser.production.min.server.js +∞% 0.00 kB 7.78 kB +∞% 0.00 kB 3.13 kB
oss-stable-semver/react-server-dom-vite/umd/react-server-dom-vite.development.js +∞% 0.00 kB 17.91 kB +∞% 0.00 kB 5.02 kB
oss-stable-semver/react-server-dom-vite/umd/react-server-dom-vite.production.min.js +∞% 0.00 kB 4.07 kB +∞% 0.00 kB 1.84 kB
oss-stable-semver/react-server-dom-vite/writer.browser.server.js +∞% 0.00 kB 0.27 kB +∞% 0.00 kB 0.17 kB
oss-stable-semver/react-server-dom-vite/writer.node.server.js +∞% 0.00 kB 0.26 kB +∞% 0.00 kB 0.17 kB
oss-stable/react-server-dom-vite/cjs/react-server-dom-vite-plugin.js +∞% 0.00 kB 5.49 kB +∞% 0.00 kB 2.21 kB
oss-stable/react-server-dom-vite/cjs/react-server-dom-vite-writer.browser.development.server.js +∞% 0.00 kB 28.03 kB +∞% 0.00 kB 7.65 kB
oss-stable/react-server-dom-vite/cjs/react-server-dom-vite-writer.browser.production.min.server.js +∞% 0.00 kB 7.56 kB +∞% 0.00 kB 3.03 kB
oss-stable/react-server-dom-vite/cjs/react-server-dom-vite-writer.node.development.server.js +∞% 0.00 kB 28.20 kB +∞% 0.00 kB 7.56 kB
oss-stable/react-server-dom-vite/cjs/react-server-dom-vite-writer.node.production.min.server.js +∞% 0.00 kB 7.75 kB +∞% 0.00 kB 3.06 kB
oss-stable/react-server-dom-vite/cjs/react-server-dom-vite.development.js +∞% 0.00 kB 16.67 kB +∞% 0.00 kB 4.90 kB
oss-stable/react-server-dom-vite/cjs/react-server-dom-vite.production.min.js +∞% 0.00 kB 3.87 kB +∞% 0.00 kB 1.74 kB
oss-stable/react-server-dom-vite/esm/react-server-dom-vite-client-proxy.js +∞% 0.00 kB 2.16 kB +∞% 0.00 kB 0.94 kB
oss-stable/react-server-dom-vite/esm/react-server-dom-vite-plugin.js +∞% 0.00 kB 5.45 kB +∞% 0.00 kB 2.19 kB
oss-stable/react-server-dom-vite/esm/react-server-dom-vite-writer.browser.server.js +∞% 0.00 kB 27.93 kB +∞% 0.00 kB 7.60 kB
oss-stable/react-server-dom-vite/esm/react-server-dom-vite-writer.node.server.js +∞% 0.00 kB 28.11 kB +∞% 0.00 kB 7.51 kB
oss-stable/react-server-dom-vite/esm/react-server-dom-vite.js +∞% 0.00 kB 16.49 kB +∞% 0.00 kB 4.84 kB
oss-stable/react-server-dom-vite/index.js +∞% 0.00 kB 0.22 kB +∞% 0.00 kB 0.16 kB
oss-stable/react-server-dom-vite/plugin.js +∞% 0.00 kB 0.08 kB +∞% 0.00 kB 0.10 kB
oss-stable/react-server-dom-vite/umd/react-server-dom-vite-writer.browser.development.server.js +∞% 0.00 kB 29.74 kB +∞% 0.00 kB 7.80 kB
oss-stable/react-server-dom-vite/umd/react-server-dom-vite-writer.browser.production.min.server.js +∞% 0.00 kB 7.78 kB +∞% 0.00 kB 3.13 kB
oss-stable/react-server-dom-vite/umd/react-server-dom-vite.development.js +∞% 0.00 kB 17.91 kB +∞% 0.00 kB 5.02 kB
oss-stable/react-server-dom-vite/umd/react-server-dom-vite.production.min.js +∞% 0.00 kB 4.07 kB +∞% 0.00 kB 1.84 kB
oss-stable/react-server-dom-vite/writer.browser.server.js +∞% 0.00 kB 0.27 kB +∞% 0.00 kB 0.17 kB
oss-stable/react-server-dom-vite/writer.node.server.js +∞% 0.00 kB 0.26 kB +∞% 0.00 kB 0.17 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
oss-experimental/react-server-dom-vite/cjs/react-server-dom-vite-plugin.js +∞% 0.00 kB 5.49 kB +∞% 0.00 kB 2.21 kB
oss-experimental/react-server-dom-vite/cjs/react-server-dom-vite-writer.browser.development.server.js +∞% 0.00 kB 28.03 kB +∞% 0.00 kB 7.65 kB
oss-experimental/react-server-dom-vite/cjs/react-server-dom-vite-writer.browser.production.min.server.js +∞% 0.00 kB 7.56 kB +∞% 0.00 kB 3.03 kB
oss-experimental/react-server-dom-vite/cjs/react-server-dom-vite-writer.node.development.server.js +∞% 0.00 kB 28.20 kB +∞% 0.00 kB 7.56 kB
oss-experimental/react-server-dom-vite/cjs/react-server-dom-vite-writer.node.production.min.server.js +∞% 0.00 kB 7.75 kB +∞% 0.00 kB 3.06 kB
oss-experimental/react-server-dom-vite/cjs/react-server-dom-vite.development.js +∞% 0.00 kB 16.67 kB +∞% 0.00 kB 4.90 kB
oss-experimental/react-server-dom-vite/cjs/react-server-dom-vite.production.min.js +∞% 0.00 kB 3.87 kB +∞% 0.00 kB 1.74 kB
oss-experimental/react-server-dom-vite/esm/react-server-dom-vite-client-proxy.js +∞% 0.00 kB 2.16 kB +∞% 0.00 kB 0.94 kB
oss-experimental/react-server-dom-vite/esm/react-server-dom-vite-plugin.js +∞% 0.00 kB 5.45 kB +∞% 0.00 kB 2.19 kB
oss-experimental/react-server-dom-vite/esm/react-server-dom-vite-writer.browser.server.js +∞% 0.00 kB 27.93 kB +∞% 0.00 kB 7.60 kB
oss-experimental/react-server-dom-vite/esm/react-server-dom-vite-writer.node.server.js +∞% 0.00 kB 28.11 kB +∞% 0.00 kB 7.51 kB
oss-experimental/react-server-dom-vite/esm/react-server-dom-vite.js +∞% 0.00 kB 16.49 kB +∞% 0.00 kB 4.84 kB
oss-experimental/react-server-dom-vite/index.js +∞% 0.00 kB 0.22 kB +∞% 0.00 kB 0.16 kB
oss-experimental/react-server-dom-vite/plugin.js +∞% 0.00 kB 0.08 kB +∞% 0.00 kB 0.10 kB
oss-experimental/react-server-dom-vite/umd/react-server-dom-vite-writer.browser.development.server.js +∞% 0.00 kB 29.74 kB +∞% 0.00 kB 7.80 kB
oss-experimental/react-server-dom-vite/umd/react-server-dom-vite-writer.browser.production.min.server.js +∞% 0.00 kB 7.78 kB +∞% 0.00 kB 3.13 kB
oss-experimental/react-server-dom-vite/umd/react-server-dom-vite.development.js +∞% 0.00 kB 17.91 kB +∞% 0.00 kB 5.02 kB
oss-experimental/react-server-dom-vite/umd/react-server-dom-vite.production.min.js +∞% 0.00 kB 4.07 kB +∞% 0.00 kB 1.84 kB
oss-experimental/react-server-dom-vite/writer.browser.server.js +∞% 0.00 kB 0.27 kB +∞% 0.00 kB 0.17 kB
oss-experimental/react-server-dom-vite/writer.node.server.js +∞% 0.00 kB 0.26 kB +∞% 0.00 kB 0.17 kB
oss-stable-semver/react-server-dom-vite/cjs/react-server-dom-vite-plugin.js +∞% 0.00 kB 5.49 kB +∞% 0.00 kB 2.21 kB
oss-stable-semver/react-server-dom-vite/cjs/react-server-dom-vite-writer.browser.development.server.js +∞% 0.00 kB 28.03 kB +∞% 0.00 kB 7.65 kB
oss-stable-semver/react-server-dom-vite/cjs/react-server-dom-vite-writer.browser.production.min.server.js +∞% 0.00 kB 7.56 kB +∞% 0.00 kB 3.03 kB
oss-stable-semver/react-server-dom-vite/cjs/react-server-dom-vite-writer.node.development.server.js +∞% 0.00 kB 28.20 kB +∞% 0.00 kB 7.56 kB
oss-stable-semver/react-server-dom-vite/cjs/react-server-dom-vite-writer.node.production.min.server.js +∞% 0.00 kB 7.75 kB +∞% 0.00 kB 3.06 kB
oss-stable-semver/react-server-dom-vite/cjs/react-server-dom-vite.development.js +∞% 0.00 kB 16.67 kB +∞% 0.00 kB 4.90 kB
oss-stable-semver/react-server-dom-vite/cjs/react-server-dom-vite.production.min.js +∞% 0.00 kB 3.87 kB +∞% 0.00 kB 1.74 kB
oss-stable-semver/react-server-dom-vite/esm/react-server-dom-vite-client-proxy.js +∞% 0.00 kB 2.16 kB +∞% 0.00 kB 0.94 kB
oss-stable-semver/react-server-dom-vite/esm/react-server-dom-vite-plugin.js +∞% 0.00 kB 5.45 kB +∞% 0.00 kB 2.19 kB
oss-stable-semver/react-server-dom-vite/esm/react-server-dom-vite-writer.browser.server.js +∞% 0.00 kB 27.93 kB +∞% 0.00 kB 7.60 kB
oss-stable-semver/react-server-dom-vite/esm/react-server-dom-vite-writer.node.server.js +∞% 0.00 kB 28.11 kB +∞% 0.00 kB 7.51 kB
oss-stable-semver/react-server-dom-vite/esm/react-server-dom-vite.js +∞% 0.00 kB 16.49 kB +∞% 0.00 kB 4.84 kB
oss-stable-semver/react-server-dom-vite/index.js +∞% 0.00 kB 0.22 kB +∞% 0.00 kB 0.16 kB
oss-stable-semver/react-server-dom-vite/plugin.js +∞% 0.00 kB 0.08 kB +∞% 0.00 kB 0.10 kB
oss-stable-semver/react-server-dom-vite/umd/react-server-dom-vite-writer.browser.development.server.js +∞% 0.00 kB 29.74 kB +∞% 0.00 kB 7.80 kB
oss-stable-semver/react-server-dom-vite/umd/react-server-dom-vite-writer.browser.production.min.server.js +∞% 0.00 kB 7.78 kB +∞% 0.00 kB 3.13 kB
oss-stable-semver/react-server-dom-vite/umd/react-server-dom-vite.development.js +∞% 0.00 kB 17.91 kB +∞% 0.00 kB 5.02 kB
oss-stable-semver/react-server-dom-vite/umd/react-server-dom-vite.production.min.js +∞% 0.00 kB 4.07 kB +∞% 0.00 kB 1.84 kB
oss-stable-semver/react-server-dom-vite/writer.browser.server.js +∞% 0.00 kB 0.27 kB +∞% 0.00 kB 0.17 kB
oss-stable-semver/react-server-dom-vite/writer.node.server.js +∞% 0.00 kB 0.26 kB +∞% 0.00 kB 0.17 kB
oss-stable/react-server-dom-vite/cjs/react-server-dom-vite-plugin.js +∞% 0.00 kB 5.49 kB +∞% 0.00 kB 2.21 kB
oss-stable/react-server-dom-vite/cjs/react-server-dom-vite-writer.browser.development.server.js +∞% 0.00 kB 28.03 kB +∞% 0.00 kB 7.65 kB
oss-stable/react-server-dom-vite/cjs/react-server-dom-vite-writer.browser.production.min.server.js +∞% 0.00 kB 7.56 kB +∞% 0.00 kB 3.03 kB
oss-stable/react-server-dom-vite/cjs/react-server-dom-vite-writer.node.development.server.js +∞% 0.00 kB 28.20 kB +∞% 0.00 kB 7.56 kB
oss-stable/react-server-dom-vite/cjs/react-server-dom-vite-writer.node.production.min.server.js +∞% 0.00 kB 7.75 kB +∞% 0.00 kB 3.06 kB
oss-stable/react-server-dom-vite/cjs/react-server-dom-vite.development.js +∞% 0.00 kB 16.67 kB +∞% 0.00 kB 4.90 kB
oss-stable/react-server-dom-vite/cjs/react-server-dom-vite.production.min.js +∞% 0.00 kB 3.87 kB +∞% 0.00 kB 1.74 kB
oss-stable/react-server-dom-vite/esm/react-server-dom-vite-client-proxy.js +∞% 0.00 kB 2.16 kB +∞% 0.00 kB 0.94 kB
oss-stable/react-server-dom-vite/esm/react-server-dom-vite-plugin.js +∞% 0.00 kB 5.45 kB +∞% 0.00 kB 2.19 kB
oss-stable/react-server-dom-vite/esm/react-server-dom-vite-writer.browser.server.js +∞% 0.00 kB 27.93 kB +∞% 0.00 kB 7.60 kB
oss-stable/react-server-dom-vite/esm/react-server-dom-vite-writer.node.server.js +∞% 0.00 kB 28.11 kB +∞% 0.00 kB 7.51 kB
oss-stable/react-server-dom-vite/esm/react-server-dom-vite.js +∞% 0.00 kB 16.49 kB +∞% 0.00 kB 4.84 kB
oss-stable/react-server-dom-vite/index.js +∞% 0.00 kB 0.22 kB +∞% 0.00 kB 0.16 kB
oss-stable/react-server-dom-vite/plugin.js +∞% 0.00 kB 0.08 kB +∞% 0.00 kB 0.10 kB
oss-stable/react-server-dom-vite/umd/react-server-dom-vite-writer.browser.development.server.js +∞% 0.00 kB 29.74 kB +∞% 0.00 kB 7.80 kB
oss-stable/react-server-dom-vite/umd/react-server-dom-vite-writer.browser.production.min.server.js +∞% 0.00 kB 7.78 kB +∞% 0.00 kB 3.13 kB
oss-stable/react-server-dom-vite/umd/react-server-dom-vite.development.js +∞% 0.00 kB 17.91 kB +∞% 0.00 kB 5.02 kB
oss-stable/react-server-dom-vite/umd/react-server-dom-vite.production.min.js +∞% 0.00 kB 4.07 kB +∞% 0.00 kB 1.84 kB
oss-stable/react-server-dom-vite/writer.browser.server.js +∞% 0.00 kB 0.27 kB +∞% 0.00 kB 0.17 kB
oss-stable/react-server-dom-vite/writer.node.server.js +∞% 0.00 kB 0.26 kB +∞% 0.00 kB 0.17 kB

Generated by 🚫 dangerJS against d6a895a

@facebook-github-bot
Copy link

@facebook-github-bot facebook-github-bot commented Dec 14, 2021

Hi @frandiox!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot
Copy link

@facebook-github-bot facebook-github-bot commented Dec 16, 2021

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
X Tutup