X Tutup
The Wayback Machine - https://web.archive.org/web/20220127141956/https://github.com/ionic-team/ionic-framework/pull/24604
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(react): setupIonicReact no longer crashes in SSR environment #24604

Merged
merged 1 commit into from Jan 19, 2022
Merged

Conversation

@liamdebeasi
Copy link
Member

@liamdebeasi liamdebeasi commented Jan 19, 2022

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

When fixing #24481 I discovered that Next.js crashes on the setupIonicReact check because document is not defined.

What is the new behavior?

  • Ensure document is defined before calling it
  • I also use the same pattern in Ionic Vue now for consistency, but the functionality is exactly the same
  • Note: The initialize function has its own window undefined check, so we do not need to repeat that in IonicVue:
    if (typeof (window as any) === 'undefined') { return; }

Does this introduce a breaking change?

  • Yes
  • No

Other information

@liamdebeasi liamdebeasi merged commit 360643d into main Jan 19, 2022
18 checks passed
@liamdebeasi liamdebeasi deleted the FW-598 branch Jan 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
X Tutup