X Tutup
The Wayback Machine - https://web.archive.org/web/20220113160124/https://github.com/github/codeql/pull/7562
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

C#: Record types are allowed to seal ToString (test only). #7562

Merged
merged 2 commits into from Jan 12, 2022
Merged

C#: Record types are allowed to seal ToString (test only). #7562

merged 2 commits into from Jan 12, 2022

Conversation

@michaelnebel
Copy link
Contributor

@michaelnebel michaelnebel commented Jan 11, 2022

In C# 10 it is allowed to declare a ToString override as sealed on record types.
This is does not require any changes to the extractor.
@github-actions github-actions bot added the C# label Jan 11, 2022
@michaelnebel michaelnebel marked this pull request as ready for review Jan 11, 2022
@michaelnebel michaelnebel requested a review from as a code owner Jan 11, 2022
@michaelnebel michaelnebel merged commit f17c110 into github:main Jan 12, 2022
16 checks passed
@michaelnebel michaelnebel deleted the csharp/record-seal-tostring branch Jan 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tamasvajk tamasvajk

Assignees
No one assigned
Labels
C#
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet
2 participants
@michaelnebel @tamasvajk
X Tutup