X Tutup
The Wayback Machine - https://web.archive.org/web/20220110175721/https://github.com/github/codeql/pull/7532
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

C#: Make support for file scoped namespace declarations. #7532

Merged
merged 3 commits into from Jan 10, 2022
Merged

C#: Make support for file scoped namespace declarations. #7532

merged 3 commits into from Jan 10, 2022
+40 −9

Conversation

@michaelnebel
Copy link
Contributor

@michaelnebel michaelnebel commented Jan 7, 2022

No description provided.

@michaelnebel michaelnebel requested a review from as a code owner Jan 7, 2022
@github-actions github-actions bot added the C# label Jan 7, 2022
hvitved
hvitved reviewed Jan 7, 2022
View changes
Copy link
Contributor

@hvitved hvitved left a comment

Looks great!

csharp/ql/test/library-tests/csharp10/FileScopedNamespace.cs Outdated Show resolved Hide resolved
csharp/ql/test/library-tests/csharp10/fileScopedNamespace.ql Show resolved Hide resolved
csharp/ql/test/library-tests/csharp10/FileScopedNamespace.cs Show resolved Hide resolved
@michaelnebel michaelnebel requested a review from hvitved Jan 7, 2022
@michaelnebel michaelnebel force-pushed the csharp/file-scoped-namespace branch from 05e62e6 to 23b8444 Jan 7, 2022
@michaelnebel
Copy link
Contributor Author

@michaelnebel michaelnebel commented Jan 7, 2022

@hvitved : There are no changes since last time, but I added and removed and empty commit to re-trigger the CI.

hvitved
hvitved approved these changes Jan 7, 2022
View changes
@michaelnebel michaelnebel merged commit 533fc7a into github:main Jan 10, 2022
16 checks passed
@michaelnebel michaelnebel deleted the csharp/file-scoped-namespace branch Jan 10, 2022
@michaelnebel michaelnebel mentioned this pull request Jan 10, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hvitved hvitved

Assignees
No one assigned
Labels
C#
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet
2 participants
@michaelnebel @hvitved
X Tutup