gh-90437: Fix __main__.py documentation wording#30480
gh-90437: Fix __main__.py documentation wording#30480riqts wants to merge 8 commits intopython:mainfrom
Conversation
|
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA). CLA MissingOur records indicate the following people have not signed the CLA: For legal reasons we need all the people listed to sign the CLA before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue. If you have recently signed the CLA, please wait at least one business day You can check yourself to see if the CLA has been received. Thanks again for the contribution, we look forward to reviewing it! |
riqts
changed the title
|
Something the NEWS check doesn't know is that we don't add NEWS entries for documentation-only fixes. I've added the appropriate label to this PR. Please remove the NEWS entry, and sorry for the confusion! |
|
Thanks for this PR! Reviewers, please note that the discussion on the b.p.o. issue is still ongoing, and this approach doesn't seem to be the leading one. |
taleinat
left a comment
taleinat
left a comment
There was a problem hiding this comment.
Formatting needs fixing, but otherwise looks good to me.
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
Co-authored-by: Tal Einat <532281+taleinat@users.noreply.github.com>
|
I have made the requested changes; please review again |
|
Thanks for making the requested changes! @taleinat: please review the changes made to this pull request. |
|
This PR is stale because it has been open for 30 days with no activity. |
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
|
Please also update the PR title to match the ticket, and reference gh-nnnn instead of bpo-nnnn 🙂 |
|
That would make the title this:
If @riqts is still playing along at home. (Not that I think my issue title is so great; I'd fully support changing that to something more meaningful as well. But not the title of this PR, which isn't any better.) |
ferdnyc
left a comment
ferdnyc
left a comment
There was a problem hiding this comment.
Added a formal Suggested Change for the apostrophe, for convenience.
merwok
changed the title
merwok
left a comment
merwok
left a comment
There was a problem hiding this comment.
Another issue on line 242:
if __name__ == '__main__'blocks. Instead, those files are kept short,
functions to execute from other modules. Those other modules can then be
→ those files are kept short, importing functions to execute from other modules
merwok
changed the title
|
@riqts could you please sign off on the PR and ensure it passes all the tests? This might help us move forward and resolve any blockers in the process. |
|
The following commit authors need to sign the Contributor License Agreement: |
|
This was completed using the commits from this PR in #116309. |
11 participants
gh-90437