X Tutup
The Wayback Machine - https://web.archive.org/web/20220111020044/https://github.com/TheAlgorithms/Java/issues/2836
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flood fill fills diagonally & errors if edges are to be filled #2836

Open
appgurueu opened this issue Nov 21, 2021 · 3 comments
Open

Flood fill fills diagonally & errors if edges are to be filled #2836

appgurueu opened this issue Nov 21, 2021 · 3 comments

Comments

@appgurueu
Copy link

@appgurueu appgurueu commented Nov 21, 2021

1f17076
It:

  1. Fills diagonally, which isn't how flood fill usually works;
  2. Lacks a check for x < width && y < height: I assume it crashes if that happens (with an AIOOB Ex.)
@siriak
Copy link
Member

@siriak siriak commented Nov 22, 2021

IMO filling diagonally is fine, it's one of the ways it can be implemented. As for the check, could you fix that and maybe add a test for that?

@github-actions
Copy link

@github-actions github-actions bot commented Dec 23, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale label Dec 23, 2021
@appgurueu
Copy link
Author

@appgurueu appgurueu commented Dec 23, 2021

What the heck, issues don't resolve themselves. The bot should be disabled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
X Tutup