X Tutup
The Wayback Machine - https://web.archive.org/web/20220103211628/https://github.com/flutter/flutter/pull/95215
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update comment about prefer_final_parameters #95215

Merged
merged 1 commit into from Dec 13, 2021

Conversation

@goderbauer
Copy link
Member

@goderbauer goderbauer commented Dec 13, 2021

https://github.com/dart-lang/linter/issues/3104

@flutter-dashboard
Copy link

@flutter-dashboard flutter-dashboard bot commented Dec 13, 2021

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat.

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@goderbauer goderbauer requested a review from Hixie Dec 13, 2021
@Hixie
Copy link
Member

@Hixie Hixie commented Dec 13, 2021

test-exempt: only affects comments

Hixie
Hixie approved these changes Dec 13, 2021
Copy link
Member

@Hixie Hixie left a comment

LGTM

@fluttergithubbot fluttergithubbot merged commit babfcb9 into flutter:master Dec 13, 2021
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
X Tutup