Requesting feedback!

I hope it's not too contentious to change all the terminology in private code; it seemed to me that leaving inconsistencies would be a poor dev experience for future maintainers.

My thanks for the detail - this represents a lot of review work. I will not be able to look at it for 10 days at least - I aim to update the PR by 2021-12-16.

Aplogies for sitting on this so long, after anamnavi put so much time into review. I will update the PR this week

@alerickson / @anamnavi - It's worth remembering that whilst nuget uses ProjectURL & LicenseURL, PowerShell Module Manifests have always used ProjectUri & LicenseUri as their properties as can be seen in the New-ModuleManifest doc

Whilst I haven't looked deeply at this repositories code base (or this PR either) we need to be sure that the module manifest is correct as people who run the following would end up being broken if the resultant manifest uses Url not Uri in all the properties in the PSData hashtable under the PrivateData HashTable.

Just thought it worth mentioning

Thanks for the feedback, I have addressed the points. Can I get a re-review?

@anamnavi you asked me to pascal-case some URIs in some strings and comments. I've changed a few. Mainly, I've used Uri where the comment refers to the parameter and URI when expressing an actual URI. That's the style I've seen the most. It seems more natural in a sentence. Want me to change?

I take that feedback to mean that URI should always be Uri in comments and strings, so I have changed all occurrences in 6c92c80

Thanks for giving us a heads up on that @kilasuit! I'm going to open up an issue so that we can test and make sure we have the 'projectUrl' or 'projectUri' and 'iconUrl' or 'iconUri' in the appropriate places. I'll open up a new PR to fix any changes there and add you to review it (no pressure to if you'd rather not).

I did publish a module to the gallery from this branch. I was then able to find it; it did have project and licese properties as set in my .psd1.

@anamnavi thanks for all the work you and @alerickson have put into this review. I have taken your review comments to mean that I should change URI => Uri in ALL comments and strings, so I've done that in ALL occurrences (there were a few that you hadn't highlighted).

The only places where all-caps URI still appear:

Path                       LineNumber Line
----                       ---------- ----
.\CHANGELOG.md                     38 - Fix bug to register repositories with local file share paths, ensuring repositories with valid URIs can be registered.
.\test\PSGetModuleInfo.xml         34       <URI N="LicenseUri">https://github.com/PowerShell/SecretManagement/blob/master/LICENSE</URI>
.\test\PSGetModuleInfo.xml         35       <URI N="ProjectUri">https://github.com/powershell/secretmanagement</URI>
.\test\PSGetTestUtils.psm1        514 .LICENSEURI$(if ($LicenseUri) {" $LicenseUri"})
.\test\PSGetTestUtils.psm1        516 .PROJECTURI$(if ($ProjectUri) {" $ProjectUri"})
.\test\PSGetTestUtils.psm1        518 .ICONURI$(if ($IconUri) {" $IconUri"})

I can haz merge?

@fsackur thank you for the hard work and being so diligent with these changes and also sharing the rule of thumb you used when changing URI => Uri in all strings and comments, that's helpful for us to know! Sorry for the late response and review, I was a little out of it after my booster shot. This looks good to me, only one minor change request, per my comment right above this one (it's just a capitalization change for consistency sake with other .psd1 files, and is just a small nitpick if you don't mind addressing that). Thank you for your contribution! :D