Formed in 2009, the Archive Team (not to be confused with the archive.org Archive-It Team) is a rogue archivist collective dedicated to saving copies of rapidly dying or deleted websites for the sake of history and digital heritage. The group is 100% composed of volunteers and interested parties, and has expanded into a large amount of related projects for saving online and digital history.
[WIP] Angular devtools migration #43473
Conversation
… inspector being selected
Marks the beginning of a migration over to building Angular devtools with Bazel. This commit brings in tooling from the canonical angular bazel example repository and includes the necessary dependencies in the package.json
…rary Allows shared-utils and protocol to be built with `bazel build projects/shared-utils` and `bazel build projects/protocol`. This lays down the necessary ground work to include these libraries as dependencies in other bazel build rules.
… served with concatjs_devserver Allows the demo-no-zone application to be built with bazel and a devserver run with `bazel run projects/demo-no-zone/src:devserver`
Allows the ng-devtools-backend to be built with bazel. Allows ng-devtools-backend to be used as a dependency in other bazel build rules.
Allows the ng-devtools library to be built with bazel. ng-devtools can now be used as a dependency in other bazel build rules.
Allows the demo app to be builtmwith bazel and a dev server started with `yarn start`.
Allows shell-chrome to be built with bazel. Currently this is built in production mode with terser minified code and the appropriate manifest and content script files to make the chrome extension work properly.
… and ng-devtools-backend These modules are necessary because concatjs_devserver needs named amd/umd modules (https://bazelbuild.github.io/rules_nodejs/Concatjs.htmlrangle/angular-devtools#third-party-code)
Previously, running tests in CI with the chromium-local browser would cause the following error "Running as root without --no-sandbox is not supported". Now the karma test suites run in a custom no sandbox browser.
Nests all angular devtools files in a directory "devtools" to be pulled into the main angular repo.
…ngular-devtools-migration
|
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the |
|
@googlebot I consent |
|
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the |
|
@googlebot I consent |
|
@googlebot I consent. |
|
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the |
|
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. |
|
@AleksanderBodurri thanks for working on this! We've just discussed this PR during the framework team sync and we are trying to assess whether this code should live in the |
This PR brings in the Angular DevTools codebase into the Angular Repo. It preserves the commit history of the original repository with a process described here.
The Angular DevTools codebase has been nested under a
devtoolsdirectory. I will be working on integrating DevTools' Unit and E2E tests with the framework repository's CI.The text was updated successfully, but these errors were encountered: