X Tutup
The Wayback Machine - https://web.archive.org/web/20211112203639/https://github.com/microsoft/TypeScript/pull/42041
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a basic dev container #42041

Merged
merged 4 commits into from Feb 16, 2021
Merged

Conversation

Projects
PR Backlog
  
Done
Linked issues

Successfully merging this pull request may close these issues.

4 participants
@mjbvz
Copy link
Contributor

@mjbvz mjbvz commented Dec 18, 2020

Adds a basic dev container. This basic development environment has tools like gulp installed and should make it easier to get started contributing to TS. The dev container also will be picked for codespaces

Fixes #42042

Adds a basic dev container. This basic development environment has tools like gulp installed
@typescript-bot
Copy link
Collaborator

@typescript-bot typescript-bot commented Dec 18, 2020

This PR doesn't have any linked issues. Please open an issue that references this PR. From there we can discuss and prioritise.

Loading

CONTRIBUTING.md Outdated
This repository includes a [development container](https://code.visualstudio.com/docs/remote/containers) that you can use to quickly create an isolated development environment with all the tools you need to start working on TypeScript. To get started with a dev container and VS Code, either:

- Clone the TypeScript repository locally and use the `Open Folder in Container` command.
- Use the `Clone Repository in Container Volume` command to clone the TypeScript repository into a new container.
Copy link
Member

@DanielRosenwasser DanielRosenwasser Dec 18, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this one go first? Sounds like it's probably more ideal for most users, but I don't know much about containers.

Loading

Copy link
Contributor Author

@mjbvz mjbvz Dec 18, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good to me. Dev containers definitely make things easy once you have VS Code and docker setup, and with Codespaces you can just connect and the container will automatically be setup for you

Loading

@sandersn sandersn added this to Not started in PR Backlog Dec 30, 2020
@sandersn sandersn requested a review from weswigham Dec 30, 2020
@sandersn sandersn moved this from Not started to Needs review in PR Backlog Dec 30, 2020
"dbaeumer.vscode-eslint"
],
"remoteUser": "node"
}
Copy link
Member

@DanielRosenwasser DanielRosenwasser Jan 4, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just for the sake of consistency, we do use spaces over tabs in the repo. Could you swap these over to spaces?

Loading

@DanielRosenwasser
Copy link
Member

@DanielRosenwasser DanielRosenwasser commented Feb 16, 2021

Looking at the dockerfile, I think I'd like us to use Volta instead of nvm in the future, but it's not a blocker.

Loading

@DanielRosenwasser DanielRosenwasser merged commit 51c73a1 into microsoft:master Feb 16, 2021
10 checks passed
Loading
PR Backlog automation moved this from Needs review to Done Feb 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
X Tutup