fix(android): dont dispose fragment on onloaded #8793
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rely on android logic
|
Thanks for the PR; I need to run some tests before we can actually merge this -- as the prior issue was a crashing issue which you now say it causes some slow downs with the patch. I would rather have some slower code (i.e. having to redraw) than crashes. So merging something that undoes that and might bring back crashes; needs some good testing just to verify that it will not create a new crashing issue. |
|
The initial crashing sample is not crashing anymore with this PR. At least I could not get it to crash |
NathanWalker
approved these changes
Aug 6, 2021
NathanWalker
merged commit 03b7715
into
NativeScript:release/8.1.0
2 of 3 checks passed
NathanWalker
added a commit
that referenced
this issue
Sep 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
As explained here #6659
That hack has bad consequences.
Also i actually cant see any wrong behavior using the sample provided in the issue and upgrading to latest N.
The text was updated successfully, but these errors were encountered: