[webview_flutter] Speculative getTitle fix #4539
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Attempts to fix the getTitle flake by running JS before accessing the title, to force the page to be fully processed by the native code. No CHANGELOG change: Description would be the same as something that is already in the NEXT section. Speculative fix for flutter/flutter#94117
|
I'll retry the tests a few times before landing. |
|
Passed once; trying again... |
|
Twice... |
|
Three times (and that's each of the four runs—{master,stable}x{app-facing,impl}—each time). We may have a winner here. |
jmagman
approved these changes
Nov 23, 2021
LGTM. Could also revert the other speculative fix if it didn't work. Up to you though.
I'm going to give a shot at reverting the other fix in this branch (that'll give us yet another run of the test) |
This reverts commit e13a469.
ditman
approved these changes
Nov 23, 2021
This'll land on red to fix the tree. After tests finish, the flaky test would have passed 4x in a row.
11 tasks
11 tasks
|
Merged on red to heal the tree. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this issue
Nov 23, 2021
amantoux
added a commit
to amantoux/plugins
that referenced
this issue
Dec 11, 2021
* [webview_flutter] getTitle flake test fix Attempts to fix the getTitle flake by running JS before accessing the title, to force the page to be fully processed by the native code. No CHANGELOG change: Description would be the same as something that is already in the NEXT section.
KyleFin
pushed a commit
to KyleFin/plugins
that referenced
this issue
Dec 21, 2021
* [webview_flutter] getTitle flake test fix Attempts to fix the getTitle flake by running JS before accessing the title, to force the page to be fully processed by the native code. No CHANGELOG change: Description would be the same as something that is already in the NEXT section.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Attempts to fix the getTitle flake by running JS before accessing the
title, to force the page to be fully processed by the native code.
No CHANGELOG change: Description would be the same as something that is
already in the NEXT section.
Speculative fix for flutter/flutter#94117
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).