X Tutup
The Wayback Machine - https://web.archive.org/web/20220517135902/https://github.com/python/cpython/pull/29537
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.8] bpo-45792: Fix contextvar.Token's intersphinx FQN (GH-29533) #29537

Merged
merged 1 commit into from Nov 16, 2021

Conversation

miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Nov 12, 2021

Since .. module:: contextvars sets the module using .. class:: contextvars.Token, intersphinx records it as contextvars.contextvars.Token.
(cherry picked from commit e501d70)

Co-authored-by: Hynek Schlawack hs@ox.cx

https://bugs.python.org/issue45792

Since `.. module:: contextvars` sets the module using `.. class:: contextvars.Token`, intersphinx records it as `contextvars.contextvars.Token`.
(cherry picked from commit e501d70)

Co-authored-by: Hynek Schlawack <hs@ox.cx>
@miss-islington
Copy link
Contributor Author

@miss-islington miss-islington commented Nov 12, 2021

@hynek and @asvetlov: Status check is done, and it's a success .

1 similar comment
@miss-islington
Copy link
Contributor Author

@miss-islington miss-islington commented Nov 12, 2021

@hynek and @asvetlov: Status check is done, and it's a success .

@miss-islington
Copy link
Contributor Author

@miss-islington miss-islington commented Nov 12, 2021

Sorry, I can't merge this PR. Reason: You're not authorized to push to this branch. Visit https://docs.github.com/articles/about-protected-branches/ for more information..

@willingc
Copy link
Sponsor Contributor

@willingc willingc commented Nov 15, 2021

@ambv Would you mind looking at merging this to the protected branch? Thanks.

@ambv ambv merged commit c37a0d9 into python:3.8 Nov 16, 2021
12 checks passed
@miss-islington miss-islington deleted the backport-e501d70-3.8 branch Nov 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA signed docs skip news
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants
X Tutup