X Tutup
The Wayback Machine - https://web.archive.org/web/20211218190916/https://github.com/angular/angular/pull/43740
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(bazel): expose esm2020 and es2020 conditions in APF package exports #43740

Closed

Conversation

@devversion
Copy link
Member

@devversion devversion commented Oct 6, 2021

See individual commits

…exports

In addition to the existing `exports` conditional exports we ship
as part of APF v13, we want to expose the non-bundled ESM2020 output
through the `esm2020` conditional name. Additionally we will expose
the flat ES2020 files through the `es2020` conditional field, allowing
consumers (like the CLI) to prioritize certain formats.

e.g. consider the case with RXJS where it currently defaults to
the ESM5 output. The CLI could now set `es2015` as the conditional
to leverage the ES2015 output of RXJS. This unveils a problem though
since this would also mean that `ES2015` output of the framework Angular
packages would be used instead of the available ES2020 output. Here is
the additional `es2020` conditional helpful as it allows the CLI to
prioritize `es2020`, fallback to `es2015` and lastly fallback to `default`.
if none do match for a certain package.
@devversion devversion requested review from IgorMinar, alxhub and clydin Oct 6, 2021
@google-cla google-cla bot added the cla: yes label Oct 6, 2021
@pullapprove pullapprove bot requested review from AndrewKushnir, atscott and gkalpak Oct 6, 2021
@devversion devversion added this to the v13 Feature Freeze milestone Oct 6, 2021
@ngbot ngbot bot removed this from the v13 Feature Freeze milestone Oct 6, 2021
@ngbot ngbot bot added this to the Backlog milestone Oct 6, 2021
@ngbot ngbot bot added this to the Backlog milestone Oct 6, 2021
@ngbot ngbot bot added this to the Backlog milestone Oct 6, 2021
This commit updates the `node` engines range for all Angular
framework packages to:

* No longer support NodeJS v12 `< 12.20`. This is done because APF v13
  uses package export patterns which are only supported as of v12.20.
  https://nodejs.org/api/packages.html#packages_subpath_patterns.

* Allows for the latest v16 NodeJS versions. This matches with the CLI
  which added NodeJS v16 support with angular/angular-cli#21854.

  We already limit this to `>= v16.10.0` in preparation to only
  supporting the LTS minors of Node v16.

BREAKING CHANGE: NodeJS versions older than `v12.20.0` are no longer
supported due to the Angular packages using the NodeJS package exports
feature with subpath patterns.
@devversion devversion force-pushed the refactor/apf-package-exports branch from 4de1f2f to 64fcea6 Oct 6, 2021
@alxhub alxhub removed this from the Backlog milestone Oct 6, 2021
@alxhub alxhub added this to the v13 Feature Freeze milestone Oct 6, 2021
clydin
clydin approved these changes Oct 6, 2021
alxhub
alxhub approved these changes Oct 6, 2021
@alxhub alxhub removed request for IgorMinar, atscott and gkalpak Oct 6, 2021
@pullapprove pullapprove bot requested review from atscott, crisbeto and gkalpak Oct 6, 2021
@alxhub alxhub removed the request for review from AndrewKushnir Oct 6, 2021
@pullapprove pullapprove bot requested a review from AndrewKushnir Oct 6, 2021
alxhub
alxhub approved these changes Oct 6, 2021
Copy link
Contributor

@alxhub alxhub left a comment

Reviewed-for: global-approvers

@dylhunn
Copy link
Contributor

@dylhunn dylhunn commented Oct 6, 2021

This PR was merged into the repository by commit e0a0d05.

@dylhunn dylhunn closed this in cd1b524 Oct 6, 2021
dylhunn added a commit that referenced this issue Oct 6, 2021
This commit updates the `node` engines range for all Angular
framework packages to:

* No longer support NodeJS v12 `< 12.20`. This is done because APF v13
  uses package export patterns which are only supported as of v12.20.
  https://nodejs.org/api/packages.html#packages_subpath_patterns.

* Allows for the latest v16 NodeJS versions. This matches with the CLI
  which added NodeJS v16 support with angular/angular-cli#21854.

  We already limit this to `>= v16.10.0` in preparation to only
  supporting the LTS minors of Node v16.

BREAKING CHANGE: NodeJS versions older than `v12.20.0` are no longer
supported due to the Angular packages using the NodeJS package exports
feature with subpath patterns.

PR Close #43740
@angular-automatic-lock-bot
Copy link

@angular-automatic-lock-bot angular-automatic-lock-bot bot commented Nov 6, 2021

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Nov 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
X Tutup