New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(bazel): expose esm2020 and es2020 conditions in APF package exports #43740
Closed
devversion
wants to merge
2
commits into
angular:master
from
devversion:refactor/apf-package-exports
Closed
feat(bazel): expose esm2020 and es2020 conditions in APF package exports #43740
devversion
wants to merge
2
commits into
angular:master
from
devversion:refactor/apf-package-exports
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…exports In addition to the existing `exports` conditional exports we ship as part of APF v13, we want to expose the non-bundled ESM2020 output through the `esm2020` conditional name. Additionally we will expose the flat ES2020 files through the `es2020` conditional field, allowing consumers (like the CLI) to prioritize certain formats. e.g. consider the case with RXJS where it currently defaults to the ESM5 output. The CLI could now set `es2015` as the conditional to leverage the ES2015 output of RXJS. This unveils a problem though since this would also mean that `ES2015` output of the framework Angular packages would be used instead of the available ES2020 output. Here is the additional `es2020` conditional helpful as it allows the CLI to prioritize `es2020`, fallback to `es2015` and lastly fallback to `default`. if none do match for a certain package.
This commit updates the `node` engines range for all Angular framework packages to: * No longer support NodeJS v12 `< 12.20`. This is done because APF v13 uses package export patterns which are only supported as of v12.20. https://nodejs.org/api/packages.html#packages_subpath_patterns. * Allows for the latest v16 NodeJS versions. This matches with the CLI which added NodeJS v16 support with angular/angular-cli#21854. We already limit this to `>= v16.10.0` in preparation to only supporting the LTS minors of Node v16. BREAKING CHANGE: NodeJS versions older than `v12.20.0` are no longer supported due to the Angular packages using the NodeJS package exports feature with subpath patterns.
clydin
approved these changes
Oct 6, 2021
alxhub
approved these changes
Oct 6, 2021
alan-agius4
approved these changes
Oct 6, 2021
|
This PR was merged into the repository by commit e0a0d05. |
dylhunn
added a commit
that referenced
this issue
Oct 6, 2021
This commit updates the `node` engines range for all Angular framework packages to: * No longer support NodeJS v12 `< 12.20`. This is done because APF v13 uses package export patterns which are only supported as of v12.20. https://nodejs.org/api/packages.html#packages_subpath_patterns. * Allows for the latest v16 NodeJS versions. This matches with the CLI which added NodeJS v16 support with angular/angular-cli#21854. We already limit this to `>= v16.10.0` in preparation to only supporting the LTS minors of Node v16. BREAKING CHANGE: NodeJS versions older than `v12.20.0` are no longer supported due to the Angular packages using the NodeJS package exports feature with subpath patterns. PR Close #43740
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.


See individual commits
The text was updated successfully, but these errors were encountered: