docs(core): apply minor improvements to the InjectionToken's api docs #43693
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dario-piotrowicz
commented
Oct 3, 2021
| @@ -19,26 +19,27 @@ import {ɵɵdefineInjectable} from './interface/defs'; | |||
| * parameterized type. | |||
| * | |||
| * `InjectionToken` is parameterized on `T` which is the type of object which will be returned by | |||
| * the `Injector`. This provides additional level of type safety. | |||
| * the `Injector`. This provides an additional level of type safety. | |||
There was a problem hiding this comment.
I am just fixing the english here... but I am not sure why it is an "additional" level of type safety instead of something like "This adds type safety." or something like that 🤔
dario-piotrowicz
force-pushed
the
aio-injection-token-api-docs
branch
from
3bdce6a to
f58821c
Compare
petebacondarwin
approved these changes
Oct 11, 2021
|
You can preview 3bdce6a at https://pr43693-3bdce6a.ngbuilds.io/. |
petebacondarwin
added
the
action: merge
alan-agius4
added
the
target: patch
petebacondarwin
added
the
merge: caretaker note
|
Caretaker: this is a simple docs only change that should not need presubmit. |
|
This PR was merged into the repository by commit f04a7c1. |
atscott
pushed a commit
that referenced
this pull request
Oct 13, 2021
atscott
pushed a commit
that referenced
this pull request
Oct 13, 2021
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Serginho
pushed a commit
to TuLotero/angular
that referenced
this pull request
Jan 20, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
Issue
Issue Number: N/A
Does this PR introduce a breaking change?