fix(docs):update input-output-diagram.svg #39900

ocapuozzo · 2020-12-01T07:10:48Z

Expression in the opposite direction in diagram ! so fixed here.
"deleteRequest" is source of event (not "target") and "crossOffITem" is one of targets of event (not "source").

PR Checklist

Please check if your PR fulfills the following requirements:

The commit message follows our guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit
Tests for the changes have been added (for bug fixes / features)
Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

Bugfix
Feature
Code style update (formatting, local variables)
Refactoring (no functional changes, no api changes)
Build related changes
CI related changes
Documentation content changes
angular.io application / infrastructure changes
Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

Yes
No

Other information

ocapuozzo · 2021-11-13T17:06:25Z

As said, diagram must be update. OutPut property is target (event emitter) not source...

mary-poppins · 2021-11-13T18:02:59Z

You can preview 8c31b69 at https://pr39900-8c31b69.ngbuilds.io/.

petebacondarwin

Sorry that this has sat unloved for almost a year @ocapuozzo. It seems it got lost in the mass of other PRs.
I have two suggestions:

I don't think that source and target are actually very useful terms to use regarding outputs. How about using "event" and "handler" instead?
Can you minify the SVG file similar to how it was before you modified it?

Thanks!

ocapuozzo · 2021-11-13T20:04:24Z

Bonjour, Yes, "event" and "handler" are direct and better terms. I 'm doing the job, (your 1 and 2 point) Olivier Le samedi 13 novembre 2021 à 10:11 -0800, Pete Bacon Darwin a écrit :

…

@petebacondarwin requested changes on this pull request. Sorry that this has sat unloved for almost a year @ocapuozzo. It seems it got lost in the mass of other PRs. I have two suggestions: I don't think that source and target are actually very useful terms to use regarding outputs. How about using "event" and "handler" instead? Can you minify the SVG file similar to how it was before you modified it? Thanks! — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe. Triage notifications on the go with GitHub Mobile for iOS or Android.

petebacondarwin · 2021-11-14T20:11:35Z

Thanks for the update @ocapuozzo - would you mind doing some git magic on this PR?
Please rebase on the current upstream master, and squash the commits into one, updating the commit message to follow our required guidelines. E.g.

docs: clarify input-output diagram

ocapuozzo · 2021-11-14T22:13:09Z

I would have liked to have done this magic, but after a few attempts I throw in the towel. When I try a rebase, I turn around with commits that are not mine ... If you could take the lead, feel free to do so. Thank you Olivier Capuozzo Le dimanche 14 novembre 2021 à 12:11 -0800, Pete Bacon Darwin a écrit :

…

Thanks for the update @ocapuozzo - would you mind doing some git magic on this PR? Please rebase on the current upstream master, and squash the commits into one, updating the commit message to follow our required guidelines. E.g. docs: clarify input-output diagram — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe. Triage notifications on the go with GitHub Mobile for iOS or Android.

petebacondarwin · 2021-11-14T22:37:54Z

@ocapuozzo - sorry you didn't get it working. Thanks for trying. I have rebased for you.

For you reference what I did was:

git fetch upstream master
git checkout patch-1
git rebase upstream/master -i
# squashed the commits and fixed the commit message
git push --force-with-lease

mary-poppins · 2021-11-14T22:44:05Z

You can preview d552e53 at https://pr39900-d552e53.ngbuilds.io/.

ocapuozzo · 2021-11-14T23:02:42Z

Perfect ! Thanks for the git commands sequence. Le dimanche 14 novembre 2021 à 14:38 -0800, Pete Bacon Darwin a écrit :

…

@ocapuozzo - sorry you didn't get it working. Thanks for trying. I have rebased for you. For you reference what I did was: git fetch upstream mastergit checkout patch-1git rebase upstream/master -i# squashed the commits and fixed the commit messagegit push --force-with-lease — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe. Triage notifications on the go with GitHub Mobile for iOS or Android.

petebacondarwin · 2021-11-15T07:41:21Z

@ocapuozzo - I actually meant that we should change the heading of the boxes in the diagram from source and target to event and handler...

ocapuozzo · 2021-11-15T15:33:52Z

Pete Bacon Darwin I understand you, but in term of "data flow" (i.e soure -> target) the new diagram is correct, and non-redondant naming. Note : Data flow is a concept used in this page. If we change "source" (of new correct diagram) by "event", we loose "data flow" concept and have 2 times "event" word : "Event" fllowing by ***@***.*** event from child" Target side in new diagram, I have changed "method" by "handler" (withholding your proposal). Le dimanche 14 novembre 2021 à 23:41 -0800, Pete Bacon Darwin a écrit :

…

@ocapuozzo - I actually meant that we should change the heading of the boxes in the diagram from source and target to event and handler... — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe. Triage notifications on the go with GitHub Mobile for iOS or Android.

petebacondarwin · 2021-11-15T15:40:22Z

OK I can live with that.

"deleteRequest" is the *event* (not target) and "crossOffItem" is the *handler* of the event (not "source").

mary-poppins · 2022-02-03T18:06:20Z

You can preview 8b4f965 at https://pr39900-8b4f965.ngbuilds.io/.

dylhunn · 2022-02-03T22:51:03Z

This PR was merged into the repository by commit f44fa4b.

"deleteRequest" is the *event* (not target) and "crossOffItem" is the *handler* of the event (not "source"). PR Close #39900

angular-automatic-lock-bot · 2022-03-06T16:06:28Z

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}

google-cla bot added the cla: yes label Dec 1, 2020

pullapprove bot requested a review from alxhub December 1, 2020 07:10

jessicajaniuk added the comp: docs label Dec 1, 2020

ngbot bot added this to the needsTriage milestone Dec 1, 2020

pullapprove bot removed the comp: docs label Dec 9, 2020

ngbot bot removed this from the needsTriage milestone Dec 9, 2020

pullapprove bot added the area: core Issues related to the framework runtime label Dec 10, 2020

ngbot bot added this to the Backlog milestone Dec 10, 2020

ocapuozzo changed the title ~~update input-output-diagram.svg~~ fix(docs):update input-output-diagram.svg Dec 30, 2020

ocapuozzo mentioned this pull request Dec 30, 2020

please update input-output-diagram.svg #39855

Closed

14 tasks

petebacondarwin added the comp: docs label Nov 6, 2021

petebacondarwin added the aio: preview label Nov 13, 2021

petebacondarwin requested a review from gkalpak November 13, 2021 18:03

petebacondarwin suggested changes Nov 13, 2021

View reviewed changes

petebacondarwin added the action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews label Nov 13, 2021

petebacondarwin added action: review The PR is still awaiting reviews from at least one requested reviewer and removed action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews labels Nov 14, 2021

petebacondarwin approved these changes Nov 15, 2021

View reviewed changes

docs: update input-output-diagram.svg

8b4f965

"deleteRequest" is the *event* (not target) and "crossOffItem" is the *handler* of the event (not "source").

atscott approved these changes Feb 3, 2022

View reviewed changes

atscott added action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Feb 3, 2022

atscott removed request for alxhub and gkalpak February 3, 2022 18:15

dylhunn closed this in f44fa4b Feb 3, 2022

dylhunn pushed a commit that referenced this pull request Feb 3, 2022

docs: update input-output-diagram.svg (#39900)

1b21629

"deleteRequest" is the *event* (not target) and "crossOffItem" is the *handler* of the event (not "source"). PR Close #39900

angular-automatic-lock-bot bot locked and limited conversation to collaborators Mar 6, 2022

Apr	MAY	Jun
	21
2024	2025	2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(docs):update input-output-diagram.svg #39900

fix(docs):update input-output-diagram.svg #39900

ocapuozzo commented Dec 1, 2020 •

edited

Loading

ocapuozzo commented Nov 13, 2021

mary-poppins commented Nov 13, 2021

petebacondarwin left a comment

ocapuozzo commented Nov 13, 2021 via email •

edited

Loading

petebacondarwin commented Nov 14, 2021

ocapuozzo commented Nov 14, 2021 via email

petebacondarwin commented Nov 14, 2021

mary-poppins commented Nov 14, 2021

ocapuozzo commented Nov 14, 2021 via email

petebacondarwin commented Nov 15, 2021

ocapuozzo commented Nov 15, 2021 via email

petebacondarwin commented Nov 15, 2021

mary-poppins commented Feb 3, 2022

dylhunn commented Feb 3, 2022

angular-automatic-lock-bot bot commented Mar 6, 2022

fix(docs):update input-output-diagram.svg #39900

fix(docs):update input-output-diagram.svg #39900

Conversation

ocapuozzo commented Dec 1, 2020 • edited Loading

PR Checklist

PR Type

What is the current behavior?

What is the new behavior?

Does this PR introduce a breaking change?

Other information

ocapuozzo commented Nov 13, 2021

mary-poppins commented Nov 13, 2021

petebacondarwin left a comment

Choose a reason for hiding this comment

ocapuozzo commented Nov 13, 2021 via email • edited Loading

petebacondarwin commented Nov 14, 2021

ocapuozzo commented Nov 14, 2021 via email

petebacondarwin commented Nov 14, 2021

mary-poppins commented Nov 14, 2021

ocapuozzo commented Nov 14, 2021 via email

petebacondarwin commented Nov 15, 2021

ocapuozzo commented Nov 15, 2021 via email

petebacondarwin commented Nov 15, 2021

mary-poppins commented Feb 3, 2022

dylhunn commented Feb 3, 2022

angular-automatic-lock-bot bot commented Mar 6, 2022

ocapuozzo commented Dec 1, 2020 •

edited

Loading

ocapuozzo commented Nov 13, 2021 via email •

edited

Loading