refactor(compiler): Shorten %COMP% to %C% #37775
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ngwattcos
force-pushed
the
shorten-attribute-3
branch
2 times, most recently
from
25d2afd
to
ede908e
This commit reduces the length of the component placeholder. No functionality changes. All spec tests were updated to use %C% instead of %COMP%.
petebacondarwin
requested changes
Dec 2, 2020
Hi @ngwattcos - sorry for the time it has taken to review this PR.
The tests have changed since you made it, so the files are now conflicted.
Further we are moving the compliance tests over to a new model, so this PR will need to update the new "test-cases" as well.
|
@ngwattcos @petebacondarwin This would be a great optimization to land. If we can get it rebased and updated, that would be great. |
|
Also, we determined that (although this shouldn't be) there is a chance of it being a breaking change, in the case where someone is relying upon the previous form of these ids. |
petebacondarwin
added
breaking changes
target: major
action: cleanup
and removed
target: patch
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
This commit reduces the length of the component placeholder. No functionality changes.
Shortening the attribute allows a smaller bundle size and a smaller download before the platform-server shis the component attribute with component ID.
All spec tests involving %COMP% have been updated to use %C%.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information
The text was updated successfully, but these errors were encountered: