X Tutup
The Wayback Machine - https://web.archive.org/web/20211112004215/https://github.com/angular/angular/pull/43684
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: make comment structure consistent in packages/core/index.ts, fix minor grammar mistakes in documentation #43684

Closed
wants to merge 3 commits into from
Closed

refactor: make comment structure consistent in packages/core/index.ts, fix minor grammar mistakes in documentation #43684

wants to merge 3 commits into from

Conversation

Reviewers

@petebacondarwin petebacondarwin

@devversion devversion

Assignees
No one assigned
Labels
action: merge cla: yes comp: docs target: patch
Projects
None yet
Milestone
Backlog
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
@import-brain @jessicajaniuk @petebacondarwin @devversion
@import-brain
Copy link
Contributor

@import-brain import-brain commented Oct 2, 2021 •
edited
Loading

Fixed second big blob of comments in packages/core/index.ts to use multiline comments
Fixed grammar mistakes in documentation throughout project

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:
import-brain added 2 commits Oct 2, 2021
@import-brain
docs: fixed minor grammar mistakes in CONTRIBUTING
579a526
@import-brain
docs: added commas to sentences in .vscode/README.md
45c3470
@google-cla google-cla bot added the cla: yes label Oct 2, 2021
@pullapprove pullapprove bot requested review from alxhub and devversion Oct 2, 2021
@import-brain
refactor(core): made comment structure consistent in index.ts
cc86ac0 
changed second big block of comments to use multi-line comment structure instead of multiple single-line comments
petebacondarwin
petebacondarwin approved these changes Oct 3, 2021
View changes
Copy link
Member

@petebacondarwin petebacondarwin left a comment •
edited
Loading

Thanks @import-brain for helping to make our docs better

I'm approving this but in general it would be great if PRs contains more significant improvements. Mostly, these additional commas are subjective and stylistic and one could argue they are not really needed.

One further thing to note for future changes. To strictly follow out guidelines, the commit message header should be in present tense rather than past. E.g. docs: fix minor grammar mistakes in CONTRIBUTING.

Reviewed-for: global-docs-approvers

Loading

@ngbot ngbot bot added this to the Backlog milestone Oct 3, 2021
@ngbot ngbot bot added this to the Backlog milestone Oct 3, 2021
@ngbot ngbot bot added this to the Backlog milestone Oct 3, 2021
@import-brain
Copy link
Contributor Author

@import-brain import-brain commented Oct 3, 2021

Thanks @import-brain for helping to make our docs better

I'm approving this but in general it would be great if PRs contains more significant improvements. Mostly, these additional commas are subjective and stylistic and one could argue they are not really needed.

One further thing to note for future changes. To strictly follow out guidelines, the commit message header should be in present tense rather than past. E.g. docs: fix minor grammar mistakes in CONTRIBUTING.

Reviewed-for: global-docs-approvers

@petebacondarwin Ah I see, thanks for the help! I'll try to make more significant improvements next time, and thanks for informing me about the present tense rule, I didn't realize that! :)

Loading

@import-brain import-brain changed the title refactor: made comment structure consistent in packages/core/index.ts, fixed minor grammar mistakes in documentation refactor: make comment structure consistent in packages/core/index.ts, fix minor grammar mistakes in documentation Oct 4, 2021
devversion
devversion approved these changes Oct 21, 2021
View changes
Copy link
Member

@devversion devversion left a comment

LGTM

Loading

@devversion devversion removed the request for review from alxhub Oct 21, 2021
@jessicajaniuk
Copy link
Contributor

@jessicajaniuk jessicajaniuk commented Oct 21, 2021

This PR was merged into the repository by commit b1c0286.

Loading

jessicajaniuk added a commit that referenced this issue Oct 21, 2021
@import-brain @jessicajaniuk
docs: added commas to sentences in .vscode/README.md (#43684)
2e941d2 
PR Close #43684
jessicajaniuk added a commit that referenced this issue Oct 21, 2021
@import-brain @jessicajaniuk
refactor(core): made comment structure consistent in index.ts (#43684)
b1c0286 
changed second big block of comments to use multi-line comment structure instead of multiple single-line comments

PR Close #43684
jessicajaniuk added a commit that referenced this issue Oct 21, 2021
@import-brain @jessicajaniuk
docs: fixed minor grammar mistakes in CONTRIBUTING (#43684)
23928a0 
PR Close #43684
jessicajaniuk added a commit that referenced this issue Oct 21, 2021
@import-brain @jessicajaniuk
docs: added commas to sentences in .vscode/README.md (#43684)
6dc4d83 
PR Close #43684
jessicajaniuk added a commit that referenced this issue Oct 21, 2021
@import-brain @jessicajaniuk
refactor(core): made comment structure consistent in index.ts (#43684)
97fc9de 
changed second big block of comments to use multi-line comment structure instead of multiple single-line comments

PR Close #43684
jessicajaniuk added a commit that referenced this issue Oct 21, 2021
@import-brain @jessicajaniuk
docs: fixed minor grammar mistakes in CONTRIBUTING (#43684)
78d94c1 
PR Close #43684
jessicajaniuk added a commit that referenced this issue Oct 21, 2021
@import-brain @jessicajaniuk
docs: added commas to sentences in .vscode/README.md (#43684)
9a12530 
PR Close #43684
jessicajaniuk added a commit that referenced this issue Oct 21, 2021
@import-brain @jessicajaniuk
refactor(core): made comment structure consistent in index.ts (#43684)
7817892 
changed second big block of comments to use multi-line comment structure instead of multiple single-line comments

PR Close #43684
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
X Tutup