X Tutup
The Wayback Machine - https://web.archive.org/web/20221229224212/https://github.com/python/typeshed/issues/3787
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing standard library xml #3787

Closed
xorsyst-python opened this issue Feb 28, 2020 · 9 comments · Fixed by #5895
Closed

Missing standard library xml #3787

xorsyst-python opened this issue Feb 28, 2020 · 9 comments · Fixed by #5895
Labels
size-medium Issue of average complexity type-incomplete Items or sub-modules missing from an existing package or module

Comments

@xorsyst-python
Copy link

xorsyst-python commented Feb 28, 2020

I'm getting

error: No library stub file for standard library module 'xml.dom.minidom'
note: (Stub files are from https://github.com/python/typeshed)
error: No library stub file for standard library module 'xml.dom'
error: No library stub file for standard library module 'xml.dom.expatbuilder'
error: No library stub file for standard library module 'xml.sax.expatreader'
error: No library stub file for standard library module 'xml.dom.pulldom'

I've updated mypy
@srittau srittau added size-large High complexity or affects many files type-incomplete Items or sub-modules missing from an existing package or module labels Feb 29, 2020
@jermenkoo
Copy link
Contributor

jermenkoo commented Mar 3, 2020

I can have a stab at some of them

@srittau
Copy link
Collaborator

srittau commented Mar 4, 2020

@jermenkoo That would be appreciated!

@adhibhuta
Copy link
Contributor

adhibhuta commented Mar 16, 2020

@jermenkoo Are you still working on it?

@jermenkoo
Copy link
Contributor

jermenkoo commented Mar 16, 2020

@lladhibhutall we can split it, just pick one of xml sub-modules and create a typestub for that

@adhibhuta
Copy link
Contributor

adhibhuta commented Mar 16, 2020

@jermenkoo Since you have been working on it for longer, you can tell me which ones you have already worked on so that I don't work on the same by mistake.

@jermenkoo
Copy link
Contributor

jermenkoo commented Mar 16, 2020

I was working on xml.dom.pulldom - everything else is upforgrabs! Let me know which one you pick so that we sync about the work here

@adhibhuta
Copy link
Contributor

adhibhuta commented Mar 16, 2020

@jermenkoo Cool, I will pick up the xml.sax.expatreader

@srittau Should we just work on the modules mentioned in the issue? There are few other modules for which stubs are not present in typeshed.

@srittau
Copy link
Collaborator

srittau commented Mar 16, 2020

@lladhibhutall Any additions are appreciated.

@jermenkoo jermenkoo mentioned this issue Mar 16, 2020
Merged
@petsuter petsuter mentioned this issue Jul 23, 2020
Closed
65 tasks
@hauntsaninja hauntsaninja mentioned this issue Sep 16, 2020
Closed
30 tasks
@hauntsaninja hauntsaninja added size-medium Issue of average complexity and removed size-large High complexity or affects many files labels May 3, 2021
@hauntsaninja
Copy link
Collaborator

hauntsaninja commented May 3, 2021

Progress has been made on this. The stubs that are very incomplete are:

xml.dom.pulldom
xml.dom.expatbuilder
xml.dom.xmlbuilder

There are missing type annotations in the others, but definitions should be more complete.

@stackswithans stackswithans mentioned this issue Aug 9, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
size-medium Issue of average complexity type-incomplete Items or sub-modules missing from an existing package or module
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add missing stdlib xml stubs stackswithans/typeshed
5 participants
@srittau @jermenkoo @hauntsaninja @adhibhuta @xorsyst-python
X Tutup