X Tutup
The Wayback Machine - https://web.archive.org/web/20211202124106/https://github.com/nodejs/node/pull/40516
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Add auth option case for url.format #40516

Merged
merged 2 commits into from Dec 2, 2021

Conversation

@wafuwafu13
Copy link
Contributor

@wafuwafu13 wafuwafu13 commented Oct 19, 2021

https://nodejs.org/dist/latest-v17.x/docs/api/url.html#urlurltohttpoptionsurl

@nodejs-github-bot

This comment has been hidden.

@nodejs-github-bot

This comment has been hidden.

@nodejs-github-bot

This comment has been hidden.

@nodejs-github-bot

This comment has been hidden.

@nodejs-github-bot

This comment has been hidden.

@nodejs-github-bot

This comment has been hidden.

@nodejs-github-bot

This comment has been hidden.

@nodejs-github-bot

This comment has been hidden.

@nodejs-github-bot

This comment has been hidden.

@nodejs-github-bot

This comment has been hidden.

@nodejs-github-bot

This comment has been hidden.

@nodejs-github-bot
Copy link
Contributor

@nodejs-github-bot nodejs-github-bot commented Nov 18, 2021

Loading

@Ayase-252
Copy link
Member

@Ayase-252 Ayase-252 commented Nov 18, 2021

@wafuwafu13

Hi, could you do a rebase to current master branch? I think a flaky test is preventing CI to get green.

Loading

@wafuwafu13
Copy link
Contributor Author

@wafuwafu13 wafuwafu13 commented Nov 18, 2021

Done:

$ git fetch --all
$ git rebase upstream/master
$ git push --force-with-lease origin urlformat-auth

Loading

@nodejs-github-bot
Copy link
Contributor

@nodejs-github-bot nodejs-github-bot commented Nov 24, 2021

Loading

@nodejs-github-bot
Copy link
Contributor

@nodejs-github-bot nodejs-github-bot commented Dec 1, 2021

Loading

@nodejs-github-bot
Copy link
Contributor

@nodejs-github-bot nodejs-github-bot commented Dec 2, 2021

Loading

@nodejs-github-bot
Copy link
Contributor

@nodejs-github-bot nodejs-github-bot commented Dec 2, 2021

Loading

@nodejs-github-bot
Copy link
Contributor

@nodejs-github-bot nodejs-github-bot commented Dec 2, 2021

Loading

Copy link
Member

@Ayase-252 Ayase-252 left a comment

Finally, we made CI green. Thanks for contribution!

Loading

@nodejs-github-bot nodejs-github-bot merged commit 9e0fb1a into nodejs:master Dec 2, 2021
55 checks passed
Loading
@nodejs-github-bot
Copy link
Contributor

@nodejs-github-bot nodejs-github-bot commented Dec 2, 2021

Landed in 9e0fb1a

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
X Tutup