New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: Add auth option case for url.format
#40516
Merged
Merged
+45
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasnell
approved these changes
Oct 24, 2021
VoltrexMaster
approved these changes
Oct 25, 2021
This comment has been hidden.
This comment has been hidden.
This comment has been hidden.
This comment has been hidden.
This comment has been hidden.
This comment has been hidden.
25 tasks
26 tasks
30 tasks
This comment has been hidden.
This comment has been hidden.
This comment has been hidden.
This comment has been hidden.
This comment has been hidden.
This comment has been hidden.
33 tasks
This comment has been hidden.
This comment has been hidden.
This comment has been hidden.
This comment has been hidden.
This comment has been hidden.
This comment has been hidden.
This comment has been hidden.
This comment has been hidden.
35 tasks
34 tasks
38 tasks
35 tasks
This comment has been hidden.
This comment has been hidden.
42 tasks
44 tasks
43 tasks
31 tasks
35 tasks
|
Hi, could you do a rebase to current master branch? I think a flaky test is preventing CI to get green. |
|
Done: $ git fetch --all
$ git rebase upstream/master
$ git push --force-with-lease origin urlformat-auth |
31 tasks
47 tasks
41 tasks
40 tasks
45 tasks
33 tasks
27 tasks
26 tasks
27 tasks
|
Landed in 9e0fb1a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.

Formed in 2009, the Archive Team (not to be confused with the archive.org Archive-It Team) is a rogue archivist collective dedicated to saving copies of rapidly dying or deleted websites for the sake of history and digital heritage. The group is 100% composed of volunteers and interested parties, and has expanded into a large amount of related projects for saving online and digital history.

https://nodejs.org/dist/latest-v17.x/docs/api/url.html#urlurltohttpoptionsurl
The text was updated successfully, but these errors were encountered: