X Tutup
The Wayback Machine - https://web.archive.org/web/20220505114315/https://github.com/python/cpython/pull/29047
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-45449: add note about PEP 585 in collections.abc's documentation #29047

Merged
merged 2 commits into from Oct 19, 2021
Merged

bpo-45449: add note about PEP 585 in collections.abc's documentation #29047

merged 2 commits into from Oct 19, 2021

Conversation

FFY00
Copy link
Member

@FFY00 FFY00 commented Oct 19, 2021 •
edited by bedevere-bot

@FFY00
bpo-45449: add note about PEP 585 in collections.abc's documentation
408d6a0 
Signed-off-by: Filipe Laíns <lains@riseup.net>
@FFY00 FFY00 requested a review from rhettinger as a code owner Oct 19, 2021
@bedevere-bot bedevere-bot added the docs label Oct 19, 2021
@FFY00 FFY00 requested review from gvanrossum and ambv Oct 19, 2021
@gvanrossum
Copy link

@gvanrossum gvanrossum commented Oct 19, 2021

Hm, I feel that there should probably a section in the docs explaining cls[…], so we can link there rather than to the PEP (which is not for beginners).

@gvanrossum
Copy link

@gvanrossum gvanrossum commented Oct 19, 2021

I'll leave the review to Lukasz then.

@ambv ambv merged commit 7bafa0c into python:main Oct 19, 2021
12 checks passed
@miss-islington
Copy link

@miss-islington miss-islington commented Oct 19, 2021

Thanks @FFY00 for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this issue Oct 19, 2021
@FFY00 @miss-islington
bpo-45449: add note about PEP 585 in collections.abc's documentation (p…
72d9662 
…ythonGH-29047)

Signed-off-by: Filipe Laíns <lains@riseup.net>

Co-authored-by: Łukasz Langa <lukasz@langa.pl>
(cherry picked from commit 7bafa0c)

Co-authored-by: Filipe Laíns <lains@riseup.net>
@bedevere-bot
Copy link

@bedevere-bot bedevere-bot commented Oct 19, 2021

GH-29067 is a backport of this pull request to the 3.10 branch.

@miss-islington
Copy link

@miss-islington miss-islington commented Oct 19, 2021

Sorry, @FFY00 and @ambv, I could not cleanly backport this to 3.9 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 7bafa0cf586227987d3d662264d491e3780024b7 3.9

ambv pushed a commit to ambv/cpython that referenced this issue Oct 19, 2021
@FFY00 @ambv
[3.9] bpo-45449: add note about PEP 585 in collections.abc's document…
dd06298 
…ation (pythonGH-29047)

Signed-off-by: Filipe Laíns <lains@riseup.net>

Co-authored-by: Łukasz Langa <lukasz@langa.pl>.
(cherry picked from commit 7bafa0c)

Co-authored-by: Filipe Laíns <lains@riseup.net>
@bedevere-bot
Copy link

@bedevere-bot bedevere-bot commented Oct 19, 2021

GH-29068 is a backport of this pull request to the 3.9 branch.

ambv pushed a commit that referenced this issue Oct 19, 2021
@miss-islington
bpo-45449: add note about PEP 585 in collections.abc's documentation (G…
092ec4b 
…H-29047) (GH-29067)

Signed-off-by: Filipe Laíns <lains@riseup.net>

Co-authored-by: Łukasz Langa <lukasz@langa.pl>
(cherry picked from commit 7bafa0c)
ambv added a commit that referenced this issue Oct 19, 2021
@ambv @FFY00
[3.9] bpo-45449: add note about PEP 585 in collections.abc's document…
a18e4e9 
…ation (GH-29047) (GH-29068)

Signed-off-by: Filipe Laíns <lains@riseup.net>

Co-authored-by: Łukasz Langa <lukasz@langa.pl>.
(cherry picked from commit 7bafa0c)

Co-authored-by: Filipe Laíns <lains@riseup.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhettinger rhettinger

@gvanrossum gvanrossum

@ambv ambv

Assignees

@ambv ambv

Labels
CLA signed docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@FFY00 @gvanrossum @miss-islington @bedevere-bot @ambv @the-knights-who-say-ni
X Tutup