X Tutup
The Wayback Machine - https://web.archive.org/web/20211017081510/https://github.com/TheAlgorithms/Python/pull/5326
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Matching min vertex cover #5326

Merged
merged 6 commits into from Oct 15, 2021
Merged

Matching min vertex cover #5326

merged 6 commits into from Oct 15, 2021
+62 −0

Conversation

@manueldilullo
Copy link
Contributor

@manueldilullo manueldilullo commented Oct 15, 2021

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.
@manueldilullo
matching algorithm for min vertex cover problem
0e80ea5
@manueldilullo
fixed hint on row 37
b04e615
@manueldilullo
changed variable names
97ba99f
algorithms-keeper[bot]
algorithms-keeper bot reviewed Oct 15, 2021
View changes
Copy link

@algorithms-keeper algorithms-keeper bot left a comment

Click here to look at the relevant links ⬇️

🔗 Relevant Links

Repository:

Python:

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options

algorithms-keeper actions can be triggered by commenting on this PR:

  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.

NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.

graphs/matching_min_vertex_cover.py Show resolved Hide resolved
@manueldilullo
provided doctest for get_edges function
014c4cd
cclauss
cclauss reviewed Oct 15, 2021
View changes
graphs/matching_min_vertex_cover.py Outdated
for node_from in graph.keys():
for node_to in graph[node_from]:
edges.add((node_from, node_to))
Copy link
Member

@cclauss cclauss Oct 15, 2021 •
edited

Suggested change
for node_from in graph.keys():
for node_to in graph[node_from]:
edges.add((node_from, node_to))
for from_node, to_nodes in graph.items():
for to_node in to_nodes:
edges.add((from_node, to_node))

dict.keys() is almost never needed in modern Python. Just iterate the dict instead: for key in graph:

Just for the mental exercise (it is too difficult to read to be put into the code!):
return {(from_node, to_node) for from_node, to_nodes in graph.items() for to_node in to_nodes}

Copy link
Contributor Author

@manueldilullo manueldilullo Oct 15, 2021

Thank you for the hint!

@manueldilullo
Removed dict.keys() iteration
5c48603
cclauss
cclauss approved these changes Oct 15, 2021
View changes
Copy link
Member

@cclauss cclauss left a comment

LGTM

@cclauss
Update matching_min_vertex_cover.py
1e7c9bc
@cclauss cclauss merged commit 1d457be into TheAlgorithms:master Oct 15, 2021
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@algorithms-keeper algorithms-keeper

@cclauss cclauss

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@manueldilullo @cclauss
X Tutup