X Tutup
The Wayback Machine - https://web.archive.org/web/20211019020953/https://github.com/TheAlgorithms/Python/pull/5357
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[mypy] fix mypy error in Project Euler Problem 092 solution 1 #5357

Merged
merged 7 commits into from Oct 17, 2021
Merged

[mypy] fix mypy error in Project Euler Problem 092 solution 1 #5357

merged 7 commits into from Oct 17, 2021
+23 −35

Conversation

@poyea
Copy link
Member

@poyea poyea commented Oct 16, 2021 •
edited

Describe your change:

> mypy project_euler/problem_092/sol1.py
Success: no issues found in 1 source file

3 items passed all tests:
   3 tests in __main__.chain
   3 tests in __main__.next_number
   2 tests in __main__.solution
8 tests in 4 items.
8 passed and 0 failed.
Test passed.
  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.
poyea and others added 2 commits Oct 16, 2021
@poyea
fix mypy error
968988d
updating DIRECTORY.md
aa01d60
@poyea poyea requested review from dhruvmanila and Kush1101 as code owners Oct 16, 2021
poyea added 2 commits Oct 16, 2021
@poyea
simplify code
c558325
@poyea
run black
add8688
@poyea
fix doc consistency
28e6b4a
@poyea
Copy link
Member Author

@poyea poyea commented Oct 16, 2021

Fixing #5091
@srishtik2310 @cclauss Your reviews please.

> mypy project_euler
Success: no issues found in 254 source files

@poyea poyea self-assigned this Oct 16, 2021
poyea added 2 commits Oct 16, 2021
@poyea
Fix doc
008e3f4
@poyea
fix doc
ca2ef28
@poyea poyea changed the title [mypy] fix mypy error in Project Euler Problem 092 [mypy] fix mypy error in Project Euler Problem 092 solution 1 Oct 16, 2021
@srishtik2310
Copy link
Contributor

@srishtik2310 srishtik2310 commented Oct 16, 2021

It is my first time contributing to open source. Surprised to see so many things could have been better. Thank you for fixing the code @poyea. Got to learn lot of things.

@cclauss cclauss merged commit 4bf2eed into master Oct 17, 2021
7 checks passed
@cclauss cclauss deleted the mypy-project-euler-092-sol-1 branch Oct 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cclauss cclauss

@dhruvmanila dhruvmanila

@Kush1101 Kush1101

Assignees

@poyea poyea

Labels
enhancement
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@poyea @srishtik2310 @cclauss
X Tutup