X Tutup
The Wayback Machine - https://web.archive.org/web/20211013113531/https://github.com/atom/atom/issues/21049
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking 鈥淪ign up for GitHub鈥, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Octicons to v10.0.0 #21049

Open
johnletey opened this issue Jul 7, 2020 路 36 comments
Open

Update Octicons to v10.0.0 #21049

johnletey opened this issue Jul 7, 2020 路 36 comments

Comments

@johnletey
Copy link

@johnletey johnletey commented Jul 7, 2020

Summary

GitHub has recently released some new snazzy octicons, and would love to see them in Atom!

Motivation

To look more cutting edge 馃槏

Describe alternatives you've considered

Additional context

@gopipofficial
Copy link

@gopipofficial gopipofficial commented Oct 4, 2020

I would like to work on this as part of Hactoberfest and to start my experience on open source. I'm working on Atom local setup and can you kindly explain to me what to achieve in this issue?. that would be helpful for me to get a start.

@sadick254
Copy link
Contributor

@sadick254 sadick254 commented Oct 5, 2020

Hey @gopipofficial the best place to start would be

.octicon-font-legacy() {
font-family: 'Octicons Regular';
src: url("icons/octicons-2.1.2.woff") format("woff");
font-weight: normal;
font-style: normal;
}
.octicon-font() {
font-family: 'Octicons Regular';
src: url("icons/octicons.woff") format("woff");
font-weight: normal;
font-style: normal;
}

However looking at the direction that github took to deliver octicons as svg rather than icon fonts, working on this would require a rework on how atom uses the icons.

Apologies I miss labeled this issue. If you are still willing to proceed working on this issue let me know.

@gopipofficial
Copy link

@gopipofficial gopipofficial commented Oct 7, 2020

I'll try my level best to achieve this before to start I'm having local setup issue working on it. Please give me sometime.

@pavan5555
Copy link

@pavan5555 pavan5555 commented Oct 8, 2020

hi @gopipofficial are you working on this ?

@gopipofficial
Copy link

@gopipofficial gopipofficial commented Oct 8, 2020

Yes, @pavan5555 ill be working on it. Unfortunately, I'm facing an atom local setup issue. Once I fixed that ill start working on it.

@gopipofficial
Copy link

@gopipofficial gopipofficial commented Oct 9, 2020

@sadick254 I regret to say this, I'm still facing an issue with the local setup. I've opened one issue for getting help on that.

@Moe82
Copy link

@Moe82 Moe82 commented Oct 21, 2020

Hi, @gopipofficial . Are you still working on this?

@gopipofficial
Copy link

@gopipofficial gopipofficial commented Oct 22, 2020

@Moe82 my local environment setup issue was fixed with the help of @sadick254 and now I started looking into the issue.

@gopipofficial
Copy link

@gopipofficial gopipofficial commented Oct 22, 2020

@sadick254 thanks for your input on setting up the local env. now its up and wanted to fix this issue. the issue is to change all the icons in the Atom from font icon to new octicons respectively right ???

@sadick254
Copy link
Contributor

@sadick254 sadick254 commented Oct 22, 2020

Thats correct @gopipofficial

@gopipofficial
Copy link

@gopipofficial gopipofficial commented Oct 23, 2020

Thanks, I'm starting with the changes.

@Solankigaming
Copy link

@Solankigaming Solankigaming commented Dec 19, 2020

Wow that was so help help full for me thnaks for sharing such a valuable information i use these tips on my website SolankiGaming! and I am able to generate a lot of traffic.

@hindidigit
Copy link

@hindidigit hindidigit commented Feb 15, 2021

It's very informative. I really appreciate your works for the newbies. I follow these on my Blog HindiDigit

@subhamagarwal624
Copy link

@subhamagarwal624 subhamagarwal624 commented Feb 20, 2021

i would like to work on it plz explain what exactly i have to do

@nidhishtyagi
Copy link

@nidhishtyagi nidhishtyagi commented Apr 9, 2021

Hey if this issue is still open I would like to work on it.

@angelstranger1111
Copy link

@angelstranger1111 angelstranger1111 commented Apr 30, 2021

Thank you so much for this article. it was very informative. i really hope you continue making great content like this. i will definently follow these tips on my blog: Gadgetsglam

@icecream17
Copy link
Contributor

@icecream17 icecream17 commented Apr 30, 2021

This issue is still open

@BIGBANGDEVTRON
Copy link

@BIGBANGDEVTRON BIGBANGDEVTRON commented May 6, 2021

姝� XML 妾斾技涔庢矑鏈変换浣曡垏瀹冪浉闂滅殑妯e紡璩囪▕銆傛枃妾旀ü濡備笅鎵�绀恒��
<rss xmlns锛歛10="http://www.w3.org/2005/Atom"鐗堟湰="2.0">

<title>绫虫牸缇呯储澶壒鏀彺 - Lync 闆昏┍鐗�</title> 绫虫牸缇呯储澶壒鏀彺 2021寰粺 鍦栵紝 2021骞�05鏈�06鏃� 12锛�51锛�09 Z https://support.microsoft.com/en-us/topic/description-of-the-cumulative-update-for-lync-2010-phone-edition-for-hp-4110-and-hp-4120-november-2011-daa89744-1e8a-809b-5a83-681226bd1c28 <title> 瑾槑Lync 2010闆昏┍鐗堢殑绱▓鏇存柊锛孒P 4110鍜孒P 4120锛�2011骞�11鏈� </title> 鎻忚堪 Lync 2010 闆昏┍鐗� HP 4110 鍜� HP 4120 鐨� 2011 骞� 11 鏈堢疮瑷堟洿鏂般�� 寮楅噷锛� 2020骞�04鏈�10鏃� 05锛�23锛�08 Z 2021-01-26T02锛�22锛�42Z https://support.microsoft.com/en-us/topic/descript...

@cloudguruab
Copy link

@cloudguruab cloudguruab commented May 16, 2021

Is this issue still open I'd like to contribute?

@UziTech
Copy link
Contributor

@UziTech UziTech commented May 16, 2021

@cloudguruab this won't be easy. Octicons quit using fonts in v5 and went with svgs. But you can try if you want to.

@cloudguruab
Copy link

@cloudguruab cloudguruab commented May 16, 2021

@UziTech I will give it a go

@cloudguruab
Copy link

@cloudguruab cloudguruab commented May 16, 2021

@ThatXliner Thank you!

@BIGBANGDEVTRON
Copy link

@BIGBANGDEVTRON BIGBANGDEVTRON commented May 17, 2021

@BIGBANGDEVTRON
Shopee_695a45941defa7ced2dfce1f9120ed77_1

@diegoD-caldasCaridad
Copy link

@diegoD-caldasCaridad diegoD-caldasCaridad commented Jun 5, 2021

@sadick254 @UziTech Good job and thanks!!!

I hope those octicons...

@ThatXliner
Copy link
Contributor

@ThatXliner ThatXliner commented Jun 6, 2021

Would performance have a hit if we instead replaced the spans with SVGs?

@parrthpanchal
Copy link

@parrthpanchal parrthpanchal commented Jun 19, 2021

Hey @UziTech @sadick254 @ThatXliner,
I want to work on this issue, I know it's hard but I will persevere to make this update

@UziTech
Copy link
Contributor

@UziTech UziTech commented Jun 19, 2021

@parrthpanchal go ahead 馃憤

@parrthpanchal
Copy link

@parrthpanchal parrthpanchal commented Jun 21, 2021

I am facing a problem while setting up atom locally for development. How can I resolve this error?

Screenshot (1)

UziTech added a commit to UziTech/atom that referenced this issue Jun 21, 2021
@UziTech
Copy link
Contributor

@UziTech UziTech commented Jun 21, 2021

Looks like it is an error in

`Command ${result.args.join(' ')} exited with code "${result.status}"`

If you delete ${result.args.join(' ')} locally it should not throw an error.

@parrthpanchal
Copy link

@parrthpanchal parrthpanchal commented Jun 21, 2021

If you delete ${result.args.join(' ')} locally it should not throw an error.

@UziTech Do you mean i should do something like this or I have misunderstood what you are trying to say?

Capture

@metafusion3D
Copy link

@metafusion3D metafusion3D commented Jun 21, 2021

WHEN WILL YOU FUCKING STOP YOUR SPAMS, HERE, ALL OF YOU?
I UNSUSCRIBED MILLION TIMES AND STILL RECIEVING YOUR SHIT !

LAST ADVISE : OR YOU ALL STOP TO SPAM MY FUC.KING MAILBOX WITH ALL YOUR SHIT, OR I FUCKING BRING YOU TO COURT !

ENOUGHT CLEAR ?

@UziTech
Copy link
Contributor

@UziTech UziTech commented Jun 22, 2021

@etothepi16
Copy link

@etothepi16 etothepi16 commented Jul 20, 2021

@metafusion3D no need to yell or make legal threats, just click the unsubscribe button under Notifications!

@Shubham29012001
Copy link

@Shubham29012001 Shubham29012001 commented Aug 16, 2021

I wish if the update would come for WordPress so that I can use it on my site https://www.shoutmeback.com/

@shashi567r
Copy link

@shashi567r shashi567r commented Sep 7, 2021

I think this is very informative. so I will use it on my blog https://gamerofficials.com/

icecream17 added a commit to icecream17/atom-update-backlog that referenced this issue Sep 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
26 participants
X Tutup