JS: add explicit this to all member calls #6873
Open
+2,070
−1,944
Conversation
erik-krogh
force-pushed
the
explicit-this
branch
3 times, most recently
from
13055c0
to
cf17018
|
Could we have this for Ruby and C# as well? :-) |
erik-krogh
force-pushed
the
explicit-this
branch
2 times, most recently
from
c8e1f8e
to
210eac0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Quoting the style guide:
"14. Always qualify calls to predicates of the same class with
this."No change note required -- this does not affect behaviour.
This PR was written by a program. I just had to revert some files that are identical with other languages.
Let me know if you don't think we should do this. I'm not completely sure myself.
The text was updated successfully, but these errors were encountered: