X Tutup
The Wayback Machine - https://web.archive.org/web/20211025233026/https://github.com/github/codeql/pull/6868
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

even more instanceof extensions #6868

Draft
wants to merge 36 commits into
base: main
Choose a base branch
from
Draft

even more instanceof extensions #6868

wants to merge 36 commits into from

Conversation

@ginsbach
Copy link
Contributor

@ginsbach ginsbach commented Oct 13, 2021 •
edited

The ql-on-ql hackathon surfaced some more opportunities for non-extending subtypes: github/codeql-ql#45

This PR builds on #6866 and implements even more of them.

The last commit is probably the most important one to review.
ginsbach added 12 commits Oct 13, 2021
@ginsbach
SuppressionScope non-extending subtype of SuppressionComment
34816b1
@ginsbach
SuppressionScope non-extending subtype of SuppressionComment
cee233e
@ginsbach
SuppressionScope non-extending subtype of SuppressionAnnotation
8c1e459
@ginsbach
GeneratedTopLevel non-extending subtype of GeneratedType
2ed7a84
@ginsbach
HtmlElementDefinition non-extending subtype of HTML::Element
f71cc18
@ginsbach
JsxElementDefinition non-extending subtype of JSXElement
c16eecd
@ginsbach
HtmlAttributeDefinition non-extending subtype of HTML::Attribute
adcb39f
@ginsbach
InvokeNode non-extending subtype of DataFlow::Impl::InvokeNodeDef
0c16dfe
@ginsbach
MethodCallNode non-extending subtype of DataFlow::Impl::MethodCallNod…
9517822 
…eDef
@ginsbach
Refinement non-extending subtype of RefinementCandidate
067698d
@ginsbach
AnalyzedExplicitPropertyWrite non-extending subtype of DataFlow::Prop…
5d04148 
…Write
@ginsbach
LinkFunctionWithScopeInjection non-extending subtype of LinkFunction
f2c2bce
@ginsbach ginsbach requested review from as code owners Oct 13, 2021
@ginsbach ginsbach changed the title Ginsbach/even more instanceof extensions even more instanceof extensions Oct 13, 2021
@ginsbach ginsbach marked this pull request as draft Oct 13, 2021
hvitved
hvitved reviewed Oct 13, 2021
View changes
Copy link
Contributor

@hvitved hvitved left a comment

C# 👍

erik-krogh
erik-krogh reviewed Oct 13, 2021
View changes
Copy link
Contributor

@erik-krogh erik-krogh left a comment

JS 👍

@ginsbach ginsbach dismissed stale reviews from erik-krogh and hvitved via 612ce48 Oct 13, 2021
@ginsbach ginsbach force-pushed the ginsbach/EvenMoreInstanceofExtensions branch from 612ce48 to 0dd396e Oct 13, 2021
@ginsbach ginsbach marked this pull request as ready for review Oct 13, 2021
@ginsbach ginsbach requested a review from hvitved Oct 13, 2021
@ginsbach ginsbach marked this pull request as draft Oct 14, 2021
@ginsbach
Copy link
Contributor Author

@ginsbach ginsbach commented Oct 14, 2021

@tausbn spotted an issue with the Python parts, I'll put the PR into draft mode for now. Apologies for the repeated reviews.

ginsbach added 21 commits Oct 14, 2021
@ginsbach
ProviderRecipeServiceInjection non-extending subtype of ProviderRecip…
710193e 
…eDefinition
@ginsbach
RequestInputAccessAsSource non-extending subtype of HTTP::RequestInpu…
0cead18 
…tAccess
@ginsbach
SuppressionScope non-extending subtype of SuppressionComment
2a75e5b
@ginsbach
LdapjsSearchFilterAsSink non-extending subtype of LdapjsSearchFilter
c7d39aa
@ginsbach
LdapjsDNArgumentAsSink non-extending subtype of LdapjsDNArgument
df33677
@ginsbach
UnpackingAssignmentSequenceTarget non-extending subtype of SequenceNode
46aac27
@ginsbach
TaintTrackingImplementation non-extending subtype of TaintTracking::C…
1df38c8 
…onfiguration
@ginsbach
EssaTaintTracking non-extending subtype of TaintTracking::Configuration
291b3a3
@ginsbach
ConfigurationAdapter non-extending subtype of Configuration
fd9227e
@ginsbach
ExternalPackage non-extending subtype of ModuleObject
30b59f5
@ginsbach
ModuleVariable non-extending subtype of GlobalVariable
aa193bb
@ginsbach
ModuleValue non-extending subtype of ModuleObjectInternal
c732852
@ginsbach
CallableValue non-extending subtype of CallableObjectInternal
c2f4ea4
@ginsbach
BoundMethodValue non-extending subtype of BoundMethodObjectInternal
54c5fac
@ginsbach
PythonFunctionValue non-extending subtype of PythonFunctionObjectInte…
10f015a 
…rnal
@ginsbach
BuiltinFunctionValue non-extending subtype of BuiltinFunctionObjectIn…
e23c2fc 
…ternal
@ginsbach
BuiltinMethodValue non-extending subtype of BuiltinMethodObjectInternal
158dfc1
@ginsbach
SequenceValue non-extending subtype of SequenceObjectInternal
084e69a
@ginsbach
PropertyValue non-extending subtype of PropertyInternal
ca1ddbb
@ginsbach
BackwardCompatiblePointToExtension non-extending subtype of CustomPoi…
1efa5d5 
…ntsToFact
@ginsbach
SuppressionScope non-extending subtype of SuppressionComment
bae1e36
@ginsbach ginsbach dismissed stale reviews from smowton and erik-krogh via 89ae7f2 Oct 14, 2021
@ginsbach ginsbach force-pushed the ginsbach/EvenMoreInstanceofExtensions branch from ec68940 to 89ae7f2 Oct 14, 2021
ginsbach added 2 commits Oct 14, 2021
@ginsbach
revert non-extending subtype relationships that introduced method amb…
cc26718 
…iguity
@ginsbach
remove disjunction case that is ruled impossible by type information
7e8e6e8
@ginsbach ginsbach force-pushed the ginsbach/EvenMoreInstanceofExtensions branch from 89ae7f2 to 7e8e6e8 Oct 14, 2021
@ginsbach
leave python as it is
70b679f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smowton smowton

@erik-krogh erik-krogh

@github/codeql-java codeql-java

@github/codeql-python codeql-python

@hvitved hvitved

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
C# Java JS no-change-note-required Python
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
@ginsbach @smowton @hvitved @erik-krogh
X Tutup