X Tutup
The Wayback Machine - https://web.archive.org/web/20211003213604/https://github.com/github/codeql/pull/6793
Skip to content

/ codeql Public

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

C++: Handle return value dereferences in ModelUtil.qll #6793

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

C++: Handle return value dereferences in ModelUtil.qll #6793

wants to merge 4 commits into from

Conversation

@MathiasVP
Copy link
Contributor

@MathiasVP MathiasVP commented Oct 1, 2021

We didn't have a case for return value dereferences in callOutput. This meant that we missed a lot of model flow.

This case should really be a WriteSideEffect, but the IR doesn't have write side effects for return values, so we just use the CallInstruction itself.
MathiasVP added 2 commits Oct 1, 2021
@MathiasVP
C++: Add return value dereference to 'callOutput'. This will need to …
3463c28 
…be modified once we get return value side effects in the IR.
@MathiasVP
C++: Accept test changes.
0679142
@MathiasVP MathiasVP added the C++ label Oct 1, 2021
@MathiasVP MathiasVP requested a review from as a code owner Oct 1, 2021
MathiasVP added 2 commits Oct 1, 2021
@MathiasVP
Merge branch 'main' into add-return-value-deref-to-model-util
cca77ed
@MathiasVP
C++: Accept test changes.
cc8b581
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github/codeql-c-analysis codeql-c-analysis

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
C++
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant
@MathiasVP
X Tutup