X Tutup
The Wayback Machine - https://web.archive.org/web/20220203074245/https://github.com/python/cpython/pull/28312
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-42135 Correct version slated for importlib.find_loader removal #28312

Merged
merged 2 commits into from Sep 13, 2021

Conversation

@hugovk
Copy link
Member

@hugovk hugovk commented Sep 13, 2021

importlib.find_loader should also be slated for removal in Python 3.12 instead of Python 3.10, like the others in GH-25169, and as documented in:

https://bugs.python.org/issue42135

Automerge-Triggered-By: GH:brettcannon

importlib.find_loader should also be slated for 3.12 like the others in pythonGH-25169 and as documented in https://docs.python.org/3.11/whatsnew/3.10.html#deprecated
@brettcannon
Copy link
Member

@brettcannon brettcannon commented Sep 13, 2021

Yep, should be backported. And a news file wouldn't hurt, but the docs are really the key thing along with What's New.

@hugovk
Copy link
Member Author

@hugovk hugovk commented Sep 13, 2021

News file added.

@miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Sep 13, 2021

@hugovk: Status check is done, and it's a success .

@brettcannon brettcannon reopened this Sep 13, 2021
@brettcannon brettcannon merged commit 9f93018 into python:main Sep 13, 2021
20 of 21 checks passed
@miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Sep 13, 2021

Thanks @hugovk for the PR, and @brettcannon for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒🤖

@bedevere-bot
Copy link

@bedevere-bot bedevere-bot commented Sep 13, 2021

GH-28321 is a backport of this pull request to the 3.10 branch.

miss-islington added a commit to miss-islington/cpython that referenced this issue Sep 13, 2021
…ythonGH-28312)

importlib.find_loader should also be slated for 3.12 like the others in pythonGH-25169 and as documented in https://docs.python.org/3.11/whatsnew/3.10.htmlGH-deprecated.
(cherry picked from commit 9f93018)

Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
brettcannon pushed a commit that referenced this issue Sep 13, 2021
…H-28312) (GH-28321)

importlib.find_loader should also be slated for 3.12 like the others in GH-25169 and as documented in https://docs.python.org/3.11/whatsnew/3.10.htmlGH-deprecated.
(cherry picked from commit 9f93018)

Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>

Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
@hugovk hugovk deleted the patch-1 branch Sep 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
X Tutup