X Tutup
The Wayback Machine - https://web.archive.org/web/20221223123950/https://github.com/python/cpython/pull/28399
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-45055: Add retry when downloading externals on Windows #28399

Merged
merged 4 commits into from Sep 20, 2021
Merged

bpo-45055: Add retry when downloading externals on Windows #28399

merged 4 commits into from Sep 20, 2021

Conversation

zooba
Copy link
Member

@zooba zooba commented Sep 16, 2021 •
edited by bedevere-bot

@zooba zooba requested a review from a team as a code owner Sep 16, 2021
gvanrossum
gvanrossum reviewed Sep 16, 2021
View changes
PCbuild/get_external.py Outdated Show resolved Hide resolved
PCbuild/get_external.py Show resolved Hide resolved
ambv
ambv reviewed Sep 17, 2021
View changes
PCbuild/get_external.py Outdated Show resolved Hide resolved
@gvanrossum @ambv
Apply Łukasz' suggestion
d379fcf 
Co-authored-by: Łukasz Langa <lukasz@langa.pl>
gvanrossum
gvanrossum approved these changes Sep 18, 2021
View changes
Copy link
Member

@gvanrossum gvanrossum left a comment

Let's go!

@gvanrossum
Copy link
Member

gvanrossum commented Sep 18, 2021

Unclear why test_asyncio should fail as a result of this. Closing and reopening. If that doesn't work let's see if a rebase works (but I can't do that, it would be up to Steve).

@gvanrossum gvanrossum closed this Sep 18, 2021
@gvanrossum gvanrossum reopened this Sep 18, 2021
@zooba zooba merged commit ef9e22b into python:main Sep 20, 2021
18 of 19 checks passed
@miss-islington
Copy link
Contributor

miss-islington commented Sep 20, 2021

Thanks @zooba for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10.
🐍🍒⛏🤖

@zooba zooba deleted the bpo-45055 branch Sep 20, 2021
@bedevere-bot
Copy link

bedevere-bot commented Sep 20, 2021

GH-28476 is a backport of this pull request to the 3.10 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 20, 2021
@zooba @miss-islington
bpo-45055: Add retry when downloading externals on Windows (pythonGH-…
89593ab 
…28399)

Co-authored-by: Łukasz Langa <lukasz@langa.pl>
(cherry picked from commit ef9e22b)

Co-authored-by: Steve Dower <steve.dower@python.org>
@bedevere-bot
Copy link

bedevere-bot commented Sep 20, 2021

GH-28477 is a backport of this pull request to the 3.9 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 20, 2021
@zooba @miss-islington
bpo-45055: Add retry when downloading externals on Windows (pythonGH-…
b321a52 
…28399)

Co-authored-by: Łukasz Langa <lukasz@langa.pl>
(cherry picked from commit ef9e22b)

Co-authored-by: Steve Dower <steve.dower@python.org>
miss-islington added a commit that referenced this pull request Sep 20, 2021
@miss-islington @zooba
bpo-45055: Add retry when downloading externals on Windows (GH-28399)
ee41d01 
Co-authored-by: Łukasz Langa <lukasz@langa.pl>
(cherry picked from commit ef9e22b)

Co-authored-by: Steve Dower <steve.dower@python.org>
miss-islington added a commit that referenced this pull request Sep 20, 2021
@miss-islington @zooba
bpo-45055: Add retry when downloading externals on Windows (GH-28399)
50c0551 
Co-authored-by: Łukasz Langa <lukasz@langa.pl>
(cherry picked from commit ef9e22b)

Co-authored-by: Steve Dower <steve.dower@python.org>
nsait-linaro pushed a commit to nsait-linaro/cpython that referenced this pull request Sep 21, 2021
@zooba @ambv @nsait-linaro
bpo-45055: Add retry when downloading externals on Windows (pythonGH-…
1474506 
…28399)

Co-authored-by: Łukasz Langa <lukasz@langa.pl>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ambv ambv

@gvanrossum gvanrossum

@python/windows-team windows-team

Assignees
No one assigned
Labels
OS-windows skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@zooba @gvanrossum @miss-islington @bedevere-bot @ambv @the-knights-who-say-ni
X Tutup