X Tutup
The Wayback Machine - https://web.archive.org/web/20211221151737/https://github.com/NativeScript/NativeScript/pull/9460
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Frame replacePage by entry #9460

Merged
merged 4 commits into from Sep 7, 2021
Merged

Conversation

@rigor789
Copy link
Member

@rigor789 rigor789 commented Jul 1, 2021

PR Checklist

What is the current behavior?

What is the new behavior?

Fixes/Implements/Closes #[Issue Number].

@cla-bot cla-bot bot added the cla: yes label Jul 1, 2021
@rigor789 rigor789 marked this pull request as draft Jul 1, 2021
@rigor789
Copy link
Member Author

@rigor789 rigor789 commented Jul 1, 2021

Set to Draft - I want to look at making the default 100ms fade transition configurable and drop the hard-coded one (while preserving old behavior).

@rigor789 rigor789 added this to the 8.1 milestone Aug 11, 2021
@rigor789 rigor789 marked this pull request as ready for review Aug 23, 2021
@rigor789 rigor789 changed the base branch from master to release/8.1.0 Sep 7, 2021
rigor789 and others added 4 commits Sep 7, 2021
* update svelte config to use svelte-loader

* handle null config

* fix: worker support in .svelte files & update snapshots

* fix after merge

Co-authored-by: halfnelson <dpershouse@gmail.com>
Co-authored-by: Igor Randjelovic <rigor789@gmail.com>
@rigor789 rigor789 force-pushed the feat/frame-replace-current-page branch from 566644d to 55095f7 Sep 7, 2021
@rigor789 rigor789 merged commit 4a5bec1 into release/8.1.0 Sep 7, 2021
3 checks passed
@rigor789 rigor789 deleted the feat/frame-replace-current-page branch Sep 7, 2021
NathanWalker added a commit that referenced this issue Sep 8, 2021
* feat: Frame replacePage by entry

* feat(webpack): improved svelte HMR (#9497)

* update svelte config to use svelte-loader

* handle null config

* fix: worker support in .svelte files & update snapshots

* fix after merge

Co-authored-by: halfnelson <dpershouse@gmail.com>
Co-authored-by: Igor Randjelovic <rigor789@gmail.com>

* feat(webpack): use svelte-loader and fallback to svelte-loader-hot

Allows running older projects

* feat: allow overwriting replacePage transition

Co-authored-by: farfromrefuge <martin.guillon@akylas.fr>
Co-authored-by: halfnelson <dpershouse@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
X Tutup