X Tutup
The Wayback Machine - https://web.archive.org/web/20240111183912/https://github.com/microsoft/vscode-python/pull/10871
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run prettier on our yaml, json and md files #10871

Merged
merged 3 commits into from Apr 1, 2020
Merged

Run prettier on our yaml, json and md files #10871

merged 3 commits into from Apr 1, 2020

Conversation

kimadeline
Copy link

@kimadeline kimadeline commented Mar 30, 2020 •
edited

Except for:

  • src/test (but reformat .vscode/settings.json)
  • src/testMultiRootWkspc (but reformat .vscode/settings.json)
  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR).
  • Title summarizes what is changing.
  • Has a news entry file (remember to thank yourself!).
  • Appropriate comments and documentation strings in the code.
  • Has sufficient logging.
  • Has telemetry for enhancements.
  • Unit tests & system/integration tests are added/updated.
  • Test plan is updated as appropriate.
  • package-lock.json has been regenerated by running npm install (if dependencies have changed).
  • The wiki is updated with any design decisions/details.

@kimadeline kimadeline added the no-changelog No news entry required label Mar 30, 2020
@kimadeline kimadeline changed the title Run prettier on our yaml and md files (except for what's in tests/) Run prettier on our yaml, json and md files Mar 30, 2020
@codecov-io
Copy link

codecov-io commented Mar 30, 2020 •
edited

Codecov Report

Merging #10871 into master will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #10871      +/-   ##
==========================================
- Coverage   60.69%   60.65%   -0.04%     
==========================================
  Files         580      580              
  Lines       31512    31530      +18     
  Branches     4480     4480              
==========================================
  Hits        19125    19125              
- Misses      11417    11433      +16     
- Partials      970      972       +2
Impacted Files Coverage Δ
src/datascience-ui/react-common/arePathsSame.ts 75.00% <0.00%> (-12.50%) ⬇️
src/client/common/utils/platform.ts 64.70% <0.00%> (-11.77%) ⬇️
src/client/linters/pydocstyle.ts 86.66% <0.00%> (-2.23%) ⬇️
...interpreter/locators/services/KnownPathsService.ts 49.05% <0.00%> (-1.93%) ⬇️
src/client/datascience/debugLocationTracker.ts 76.56% <0.00%> (-1.57%) ⬇️
src/client/common/process/proc.ts 14.49% <0.00%> (-0.73%) ⬇️
src/client/common/featureDeprecationManager.ts 40.90% <0.00%> (-0.63%) ⬇️
...rpreter/locators/services/baseVirtualEnvService.ts 28.07% <0.00%> (-0.51%) ⬇️
src/client/linters/lintingEngine.ts 20.00% <0.00%> (-0.21%) ⬇️
.../client/testing/common/managers/baseTestManager.ts 45.13% <0.00%> (-0.18%) ⬇️
... and 23 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c10a89d...3c94e51. Read the comment docs.

rchiodo
rchiodo approved these changes Mar 30, 2020
View reviewed changes
Copy link

@rchiodo rchiodo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@sonarcloud
Copy link

sonarcloud bot commented Mar 31, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@kimadeline
Copy link
Author

Finally the single workspace tests stopped timing out 🙏

@kimadeline kimadeline merged commit 4f774d9 into microsoft:master Apr 1, 2020
@kimadeline kimadeline deleted the format-non-ts-files branch April 1, 2020 17:19
@lock lock bot locked as resolved and limited conversation to collaborators Apr 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@brettcannon brettcannon brettcannon approved these changes

@rchiodo rchiodo rchiodo approved these changes

@DonJayamanne DonJayamanne Awaiting requested review from DonJayamanne

@karthiknadig karthiknadig Awaiting requested review from karthiknadig

Assignees
No one assigned
Labels
no-changelog No news entry required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@kimadeline @codecov-io @brettcannon @rchiodo
X Tutup