bpo-24234: fix bytes.bytes to not truncate at a zero byte #27902

mdickinson · 2021-08-23T10:35:12Z

Fixes buildbot failures introduced in GH-27901.

https://bugs.python.org/issue24234

bedevere-bot · 2021-08-23T10:37:10Z

🤖 New build scheduled with the buildbot fleet by @mdickinson for commit 72ea593 🤖

If you want to schedule another build, you need to add the "🔨 test-with-buildbots" label again.

corona10

@mdickinson Thank you for quick fix 👍
LGTM

mdickinson · 2021-08-23T12:27:17Z

The s390x buildbot is reporting:

test_typing leaked [1, 1, 1] memory blocks, sum=3

corona10 · 2021-08-23T12:51:50Z

@mdickinson Other Refleak tests doesn't report the issue :(

mdickinson · 2021-08-23T14:23:50Z

I'll merge anyway - this change is obviously needed. The Arch Linux buildbot failure looks unrelated, and has been happening for a while. We can keep an eye on the s390x buildbot for a while to see if the test_typing refleak is persistent.

mdickinson · 2021-08-26T08:53:01Z

The s390x buildbot is reporting [...]

There have been 9 runs of that buildbot since; none of them have reproduced that same test_typing leak, so I think we can be reasonably confident that it wasn't caused by this PR.

Fix bytes.__bytes__ to not truncate at a zero byte

72ea593

the-knights-who-say-ni added the CLA signed label Aug 23, 2021

bedevere-bot added the awaiting core review label Aug 23, 2021

mdickinson added skip news type-bugfix labels Aug 23, 2021

mdickinson requested a review from corona10 Aug 23, 2021

mdickinson added the 🔨 test-with-buildbots label Aug 23, 2021

bedevere-bot removed the 🔨 test-with-buildbots label Aug 23, 2021

corona10 approved these changes Aug 23, 2021

View changes

bedevere-bot added awaiting merge and removed awaiting core review labels Aug 23, 2021

bedevere-bot removed the awaiting merge label Aug 23, 2021

mdickinson deleted the mdickinson:bpo-24234-fix-bytes-bytes branch Aug 23, 2021

Aug	SEP	Oct
	01
2020	2021	2022

python / cpython

bpo-24234: fix bytes.bytes to not truncate at a zero byte #27902

bpo-24234: fix bytes.bytes to not truncate at a zero byte #27902

mdickinson commented Aug 23, 2021 •

edited by bedevere-bot

bedevere-bot commented Aug 23, 2021

corona10 left a comment

mdickinson commented Aug 23, 2021

corona10 commented Aug 23, 2021

mdickinson commented Aug 23, 2021

mdickinson commented Aug 26, 2021

python / cpython

Sponsor python/cpython

bpo-24234: fix bytes.__bytes__ to not truncate at a zero byte #27902

bpo-24234: fix bytes.__bytes__ to not truncate at a zero byte #27902

Conversation

mdickinson commented Aug 23, 2021 • edited by bedevere-bot

bedevere-bot commented Aug 23, 2021

corona10 left a comment

mdickinson commented Aug 23, 2021

corona10 commented Aug 23, 2021

mdickinson commented Aug 23, 2021

mdickinson commented Aug 26, 2021

bpo-24234: fix bytes.bytes to not truncate at a zero byte #27902

bpo-24234: fix bytes.bytes to not truncate at a zero byte #27902

mdickinson commented Aug 23, 2021 •

edited by bedevere-bot