Add randomly-ordered unit test run to GHA workflow #328
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
This PR adds a single PHPUnit run that is randomly ordered.
This can detect scenarios where the test makes assumptions that are only fulfilled by global state manipulated by a previous test, but are not true in the actual logic to be tested.
In case such a randomly ordered test run fails, the random seed can be found in the GHA log so that this particular ordering can be replicated locally.
Also, to make this work, it also fixes the one test that was dependent on ordering (
Dom\ElementTest::testAddAmpAction)./cc @swissspidy
The text was updated successfully, but these errors were encountered: