X Tutup
The Wayback Machine - https://web.archive.org/web/20211112004508/https://github.com/angular/angular/pull/41740
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: delete integration test for language service plugin #41740

Closed
wants to merge 1 commit into from
Closed

test: delete integration test for language service plugin #41740

wants to merge 1 commit into from

Conversation

Reviewers

@atscott atscott

@josephperrott josephperrott

@alan-agius4 alan-agius4

Assignees
No one assigned
Labels
action: merge cla: yes comp: language-service target: rc
Projects
None yet
Milestone
Backlog
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
@kyliau @atscott @josephperrott @alan-agius4
@kyliau
Copy link
Contributor

@kyliau kyliau commented Apr 21, 2021

This commit deletes the integration test for @angular/language-service
as a plugin to the standard tsserver.

In version 12, Ivy LS will replace legacy View Engine LS as the default,
and Ivy LS plugin cannot be loaded via tsconfig.json due to the need to
run ngcc. This makes the test irrelevant.

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information
@kyliau
test: delete integration test for language service plugin
d77ce1f 
This commit deletes the integration test for `@angular/language-service`
as a plugin to the standard tsserver.

In version 12, Ivy LS will replace legacy View Engine LS as the default,
and Ivy LS plugin cannot be loaded via `tsconfig.json` due to the need to
run ngcc. This makes the test irrelevant.
@kyliau kyliau requested review from atscott and alan-agius4 Apr 21, 2021
@ngbot ngbot bot added this to the Backlog milestone Apr 21, 2021
@google-cla google-cla bot added the cla: yes label Apr 21, 2021
@pullapprove pullapprove bot requested a review from IgorMinar Apr 21, 2021
alan-agius4
alan-agius4 approved these changes Apr 21, 2021
View changes
Copy link
Contributor

@alan-agius4 alan-agius4 left a comment

LGTM,

Side note, this test is also rather flakey.

Loading

@kyliau kyliau requested review from josephperrott and removed request for IgorMinar Apr 22, 2021
josephperrott
josephperrott approved these changes Apr 23, 2021
View changes
Copy link
Member

@josephperrott josephperrott left a comment

LGTM

Loading

jessicajaniuk added a commit that referenced this issue Apr 23, 2021
@kyliau @jessicajaniuk
test: delete integration test for language service plugin (#41740)
5ffecd9 
This commit deletes the integration test for `@angular/language-service`
as a plugin to the standard tsserver.

In version 12, Ivy LS will replace legacy View Engine LS as the default,
and Ivy LS plugin cannot be loaded via `tsconfig.json` due to the need to
run ngcc. This makes the test irrelevant.

PR Close #41740
@angular-automatic-lock-bot
Copy link

@angular-automatic-lock-bot angular-automatic-lock-bot bot commented May 24, 2021

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

Loading

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators May 24, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
X Tutup