Formed in 2009, the Archive Team (not to be confused with the archive.org Archive-It Team) is a rogue archivist collective dedicated to saving copies of rapidly dying or deleted websites for the sake of history and digital heritage. The group is 100% composed of volunteers and interested parties, and has expanded into a large amount of related projects for saving online and digital history.
lib: refactor to use optional chaining #38697
Open
+25
−25
Conversation
This PR migrates expressions such as `a ? a.b : c` to `a?.b ?? c` Codemod script: https://github.com/pd4d10/nodejs-codemod/blob/main/src/optional-chaining.ts
|
I'm not sure we want to do that after #38245... |
| @@ -561,7 +561,7 @@ class Control extends EventEmitter { | |||
| } | |||
|
|
|||
| get fd() { | |||
| return this.#channel ? this.#channel.fd : undefined; | |||
| return this.#channel?.fd ?? undefined; | |||
aduh95
May 16, 2021
Contributor
Suggested change
| return this.#channel?.fd ?? undefined; | |
| return this.#channel?.fd; |
| @@ -221,7 +221,7 @@ const proxySocketHandler = { | |||
| if (stream.destroyed) | |||
| return false; | |||
| const request = stream[kRequest]; | |||
| return request ? request.readable : stream.readable; | |||
| return request?.readable ?? stream.readable; | |||
aduh95
May 16, 2021
Contributor
Suggested change
| return request?.readable ?? stream.readable; | |
| return stream[kRequest]?.readable ?? stream.readable; |
| @@ -199,7 +199,7 @@ function debugStream(id, sessionType, message, ...args) { | |||
|
|
|||
| function debugStreamObj(stream, message, ...args) { | |||
| const session = stream[kSession]; | |||
| const type = session ? session[kType] : undefined; | |||
| const type = session?.kType ?? undefined; | |||
aduh95
May 16, 2021
•
Contributor
Suggested change
| const type = session?.kType ?? undefined; | |
| const type = stream[kSession]?.[kType]; |
| @@ -709,7 +709,7 @@ OutgoingMessage.prototype.write = function write(chunk, encoding, callback) { | |||
| }; | |||
|
|
|||
| function onError(msg, err, callback) { | |||
| const triggerAsyncId = msg.socket ? msg.socket[async_id_symbol] : undefined; | |||
| const triggerAsyncId = msg.socket?.[async_id_symbol] ?? undefined; | |||
aduh95
May 16, 2021
Contributor
Suggested change
| const triggerAsyncId = msg.socket?.[async_id_symbol] ?? undefined; | |
| const triggerAsyncId = msg.socket?.[async_id_symbol]; |
OK. Given this information, I guess we should hold it until the performance issues solved. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
This PR migrates expressions such as
a ? a.b : ctoa?.b ?? cCodemod script:
https://github.com/pd4d10/nodejs-codemod/blob/main/src/optional-chaining.ts
Also see:
#38609