build: enable backtrace when V8 is built for PPC and S390x #32113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
build
|
cc: @nodejs/platform-ppc @nodejs/platform-s390 |
sam-github
added
ppc
bnoordhuis
approved these changes
Mar 6, 2020
|
@miladfarca can you take a look as well? |
|
Changes lgtm. |
miladfarca
approved these changes
Mar 6, 2020
Co-Authored-By: Ben Noordhuis <info@bnoordhuis.nl>
addaleax
approved these changes
Mar 8, 2020
mmarchini
pushed a commit
that referenced
this issue
Mar 8, 2020
Refs: nodejs/node-v8#119 PR-URL: #32113 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
|
Landed in c49286b |
MylesBorins
pushed a commit
that referenced
this issue
Mar 9, 2020
Refs: nodejs/node-v8#119 PR-URL: #32113 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
Merged
codebytere
pushed a commit
that referenced
this issue
Mar 16, 2020
Refs: nodejs/node-v8#119 PR-URL: #32113 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
codebytere
pushed a commit
that referenced
this issue
Mar 17, 2020
Refs: nodejs/node-v8#119 PR-URL: #32113 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
Merged
codebytere
pushed a commit
that referenced
this issue
Mar 23, 2020
Refs: nodejs/node-v8#119 PR-URL: #32113 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
codebytere
pushed a commit
that referenced
this issue
Mar 30, 2020
Refs: nodejs/node-v8#119 PR-URL: #32113 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
codebytere
added a commit
to electron/electron
that referenced
this issue
Apr 13, 2020
richardlau
pushed a commit
to richardlau/node-1
that referenced
this issue
Oct 5, 2020
Refs: nodejs/node-v8#119 PR-URL: nodejs#32113 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Refs: nodejs/node-v8#119
Cherry-picked from
canary-baseChecklist
make -j4 test(UNIX), orvcbuild test(Windows) passes