X Tutup
The Wayback Machine - https://web.archive.org/web/20210415082823/https://github.com/nodejs/node/pull/37678
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2021-04-20, Version 16.0.0 (Current) #37678

Open
wants to merge 1 commit into
base: v16.x
from
Open

2021-04-20, Version 16.0.0 (Current) #37678

wants to merge 1 commit into from

Conversation

@BethGriggs
Copy link
Member

@BethGriggs BethGriggs commented Mar 9, 2021

Release Date: 2021-04-20
Proposed major cut-off: 2021-03-23

(Early draft PR to enable test builds. Expected to be updated weekly up until ~1 week before the release.)


2021-04-20, Version 16.0.0 (Current), @BethGriggs

Notable Changes

Deprecations and Removals

  • (SEMVER-MAJOR) fs: remove permissive rmdir recursive (Antoine du Hamel) #37216
  • (SEMVER-MAJOR) fs: runtime deprecate rmdir recursive option (Antoine du Hamel) #37302
  • (SEMVER-MAJOR) lib: runtime deprecate access to process.binding('http_parser') (James M Snell) #37813
  • (SEMVER-MAJOR) lib: runtime deprecate access to process.binding('url') (James M Snell) #37799
  • (SEMVER-MAJOR) lib: make process.binding('util') return only type checkers (Anna Henningsen) #37819
  • (SEMVER-MAJOR) lib: runtime deprecate access to process.binding('crypto') (James M Snell) #37790
  • (SEMVER-MAJOR) lib: runtime deprecate access to process.binding('signal_wrap') (James M Snell) #37800
  • (SEMVER-MAJOR) lib: runtime deprecate access to process.binding('v8') (James M Snell) #37789
  • (SEMVER-MAJOR) lib: runtime deprecate access to process.binding('async_wrap') (James M Snell) #37576
  • (SEMVER-MAJOR) module: remove module.createRequireFromPath (Antoine du Hamel) #37201
  • (SEMVER-MAJOR) module: runtime deprecate subpath folder mappings (Antoine du Hamel) #37215
  • (SEMVER-MAJOR) module: runtime deprecate "main" index and extension lookups (Antoine du Hamel) #37206
  • (SEMVER-MAJOR) module: runtime deprecate invalid package.json main entries (Antoine du Hamel) #37204
  • (SEMVER-MAJOR) process: runtime deprecate changing process.config (James M Snell) #36902

Stable Timers Promises API

The Timers Promises API provides an alternative set of timer functions that return Promise objects. Added in Node.js v15.0.0, in this release they graduate from experimental status to stable.

Contributed by James Snell - #38112

Toolchain and Compiler Upgrades

  • build: update Makefile to support fat binary (Ash Cripps) #37861
  • build: warn for gcc versions earlier than 8.3.0 (Richard Lau) #37935
  • (SEMVER-MAJOR) doc: update minimum supported Xcode to 11 (Michaël Zasso) #37872
  • (SEMVER-MAJOR) doc: update minimum supported GCC to 8.3 (Michaël Zasso) #37871
  • (SEMVER-MAJOR) doc: update AIX to GCC8 for v16.x (Ash Cripps) #37677

V8 9.0

The V8 JavaScript engine is updated to V8 9.0, including performance tweaks and improvements.

This update also brings the ECMAScript RegExp Match Indices, which provide the start and end indices of the captured string. The indices array is available via the .indices property on match objects when the regular expression has the /d flag.

Contributed by Michaël Zasso - #37587

Other Notable Changes

  • (SEMVER-MINOR) assert: graduate assert.match and assert.doesNotMatch (James M Snell) #38111
  • (SEMVER-MAJOR) buffer: expose btoa and atob as globals (James M Snell) #37786
  • (SEMVER-MINOR) http: add http.ClientRequest.getRawHeaderNames() (simov) #37660
  • (SEMVER-MAJOR) lib,src: update cluster to use Parent (Michael Dawson) #36478
  • (SEMVER-MINOR) module: add support for node:‑prefixed require(…) calls (ExE Boss) #37246
  • (SEMVER-MINOR) repl: add auto‑completion for node:‑prefixed require(…) calls (ExE Boss) #37246

Semver-Major Commits

  • [324a6c235a] - (SEMVER-MAJOR) async_hooks: add thisArg to AsyncResource.bind (James M Snell) #36782
  • [d1e2184c8e] - (SEMVER-MAJOR) buffer: expose btoa and atob as globals (James M Snell) #37786
  • [1d8c022544] - (SEMVER-MAJOR) build: update Makefile to support fat binary (Ash Cripps) #37861
  • [a572a4e34e] - (SEMVER-MAJOR) build: reset embedder string to "-node.0" (Michaël Zasso) #37587
  • [38f32386c1] - (SEMVER-MAJOR) build: include minimal V8 headers in distribution (Michaël Zasso) #37570
  • [f3c7078245] - (SEMVER-MAJOR) build: reset embedder string to "-node.0" (Michaël Zasso) #37330
  • [842389839b] - (SEMVER-MAJOR) build: reset embedder string to "-node.0" (Michaël Zasso) #36139
  • [a19af5ee71] - (SEMVER-MAJOR) build: use C++11 ABI with libstdc++ (Anna Henningsen) #36634
  • [8d6b74d347] - (SEMVER-MAJOR) build: enable ASLR (PIE) on OS X (woodfairy) #35704
  • [98d1ae47cf] - (SEMVER-MAJOR) build: reset embedder string to "-node.0" (Michaël Zasso) #35700
  • [64d5be25ab] - (SEMVER-MAJOR) deps: V8: cherry-pick 1648e050cade (Michaël Zasso) #37587
  • [621b544909] - (SEMVER-MAJOR) deps: silence irrelevant V8 warnings (Michaël Zasso) #37587
  • [0d78bc3101] - (SEMVER-MAJOR) deps: fix V8 build issue with inline methods (Jiawen Geng) #35415
  • [5214918856] - (SEMVER-MAJOR) deps: make v8.h compatible with VS2015 (Joao Reis) #32116
  • [6b3caf77b2] - (SEMVER-MAJOR) deps: V8: forward declaration of Rtl\*FunctionTable (Refael Ackermann) #32116
  • [d0a032fafb] - (SEMVER-MAJOR) deps: V8: patch register-arm64.h (Refael Ackermann) #32116
  • [c8b2fa642e] - (SEMVER-MAJOR) deps: V8: un-cherry-pick bd019bd (Refael Ackermann) #32116
  • [732ad99e47] - (SEMVER-MAJOR) deps: update V8 to 9.0.257.11 (Michaël Zasso) #37587
  • [43cc8e4b2e] - (SEMVER-MAJOR) deps: bump minimum ICU version to 68 (Michaël Zasso) #37330
  • [8eeecc19ae] - (SEMVER-MAJOR) deps: V8: cherry-pick 8957d4677aa7 (Michaël Zasso) #37330
  • [b186142a0b] - (SEMVER-MAJOR) deps: V8: backport a11395433dbd (Michaël Zasso) #37330
  • [290f2d8d3e] - (SEMVER-MAJOR) deps: V8: cherry-pick deb0813166f3 (Michaël Zasso) #36139
  • [63ed0b8bfe] - (SEMVER-MAJOR) deps: V8: cherry-pick 9a6a22874c81 (Michaël Zasso) #36139
  • [47f1c5257a] - (SEMVER-MAJOR) deps: silence irrelevant V8 warning (Michaël Zasso) #37330
  • [19d975241f] - (SEMVER-MAJOR) deps: workaround stod() limitations on SmartOS (Colin Ihrig) #37330
  • [70f928c6a6] - (SEMVER-MAJOR) deps: fix V8 build issue with inline methods (Jiawen Geng) #35415
  • [b045e39513] - (SEMVER-MAJOR) deps: patch V8 to run on Xcode 8 (Mary Marchini) #32116
  • [32725d2224] - (SEMVER-MAJOR) deps: make v8.h compatible with VS2015 (Joao Reis) #32116
  • [fe3cee7b37] - (SEMVER-MAJOR) deps: V8: forward declaration of Rtl\*FunctionTable (Refael Ackermann) #32116
  • [b2d05f7349] - (SEMVER-MAJOR) deps: V8: patch register-arm64.h (Refael Ackermann) #32116
  • [c7a0ab4e3d] - (SEMVER-MAJOR) deps: patch V8 to run on older XCode versions (Ujjwal Sharma) #32116
  • [60b623ee90] - (SEMVER-MAJOR) deps: V8: un-cherry-pick bd019bd (Refael Ackermann) #32116
  • [c5ff019a4e] - (SEMVER-MAJOR) deps: update V8 to 8.9.255.19 (Michaël Zasso) #37330
  • [577ff9fee5] - (SEMVER-MAJOR) deps: V8: cherry-pick deb0813166f3 (Michaël Zasso) #36139
  • [00e1c7ea83] - (SEMVER-MAJOR) deps: V8: cherry-pick 9a6a22874c81 (Michaël Zasso) #36139
  • [ee01d6b7fc] - (SEMVER-MAJOR) deps: V8: cherry-pick 2059ee813359 (Michaël Zasso) #36139
  • [2dad8d43cc] - (SEMVER-MAJOR) deps: V8: cherry-pick bde7ee5473d6 (Michaël Zasso) #36139
  • [3046131ea0] - (SEMVER-MAJOR) deps: V8: cherry-pick 9a712984025e (Michaël Zasso) #36139
  • [d178d0738f] - (SEMVER-MAJOR) deps: V8: cherry-pick 0b96e5b0bfb2 (Michaël Zasso) #36139
  • [5c71ea151a] - (SEMVER-MAJOR) deps: V8: cherry-pick fbb28902e049 (Michaël Zasso) #36139
  • [c8e15cd2c6] - (SEMVER-MAJOR) deps: V8: cherry-pick 821fb3883a8e (Michaël Zasso) #35700
  • [b0d67426af] - (SEMVER-MAJOR) deps: workaround stod() limitations on SmartOS (Colin Ihrig) #36139
  • [c8a658ac53] - (SEMVER-MAJOR) deps: fix V8 build issue with inline methods (Jiawen Geng) #35415
  • [153b8cea36] - (SEMVER-MAJOR) deps: patch V8 to run on Xcode 8 (Mary Marchini) #32116
  • [a785984133] - (SEMVER-MAJOR) deps: V8: silence irrelevant warnings (Michaël Zasso) #32116
  • [246c9b8c31] - (SEMVER-MAJOR) deps: make v8.h compatible with VS2015 (Joao Reis) #32116
  • [96a567f9e9] - (SEMVER-MAJOR) deps: V8: forward declaration of Rtl\*FunctionTable (Refael Ackermann) #32116
  • [e74383cecb] - (SEMVER-MAJOR) deps: V8: patch register-arm64.h (Refael Ackermann) #32116
  • [732847f1eb] - (SEMVER-MAJOR) deps: patch V8 to run on older XCode versions (Ujjwal Sharma) #32116
  • [70171d186f] - (SEMVER-MAJOR) deps: V8: un-cherry-pick bd019bd (Refael Ackermann) #32116
  • [c7b3292251] - (SEMVER-MAJOR) deps: update V8 to 8.8.278.17 (Michaël Zasso) #36139
  • [15c91c6dd5] - (SEMVER-MAJOR) deps: V8: cherry-pick 821fb3883a8e (Michaël Zasso) #35700
  • [40b2fa4832] - (SEMVER-MAJOR) deps: V8: cherry-pick 45e49775f5a3 (Michaël Zasso) #35700
  • [cd91ab5865] - (SEMVER-MAJOR) deps: V8: cherry-pick 7b3a27b7ae65 (Michaël Zasso) #35700
  • [f4fc099080] - (SEMVER-MAJOR) deps: V8: cherry-pick d76abfed3512 (Michaël Zasso) #35415
  • [6200176ef0] - (SEMVER-MAJOR) deps: fix V8 build issue with inline methods (Jiawen Geng) #35415
  • [bd5642deb9] - (SEMVER-MAJOR) deps: update V8 postmortem metadata script (Colin Ihrig) #35415
  • [9ae7159216] - (SEMVER-MAJOR) deps: update V8 postmortem metadata script (Colin Ihrig) #33579
  • [f4b4e21b2f] - (SEMVER-MAJOR) deps: patch V8 to run on Xcode 8 (Mary Marchini) #32116
  • [f6a84540d8] - (SEMVER-MAJOR) deps: V8: silence irrelevant warnings (Michaël Zasso) #32116
  • [bbc3f46572] - (SEMVER-MAJOR) deps: make v8.h compatible with VS2015 (Joao Reis) #32116
  • [0c988642dc] - (SEMVER-MAJOR) deps: V8: forward declaration of Rtl\*FunctionTable (Refael Ackermann) #32116
  • [703bf933d4] - (SEMVER-MAJOR) deps: V8: patch register-arm64.h (Refael Ackermann) #32116
  • [5451975b18] - (SEMVER-MAJOR) deps: patch V8 to run on older XCode versions (Ujjwal Sharma) #32116
  • [c460f7af4d] - (SEMVER-MAJOR) deps: V8: un-cherry-pick bd019bd (Refael Ackermann) #32116
  • [48db20f6f5] - (SEMVER-MAJOR) deps: update V8 to 8.7.220 (Michaël Zasso) #35700
  • [d85e1f0703] - (SEMVER-MAJOR) dns: use url module instead of punycode for IDNA (Antoine du Hamel) #35091
  • [290c158018] - (SEMVER-MAJOR) doc: update minimum supported Xcode to 11 (Michaël Zasso) #37872
  • [1ff2918d80] - (SEMVER-MAJOR) doc: update minimum supported GCC to 8.3 (Michaël Zasso) #37871
  • [2706e67116] - (SEMVER-MAJOR) doc: update AIX to GCC8 for v16.x (Ash Cripps) #37677
  • [ac2c8c530d] - (SEMVER-MAJOR) doc: fixup http.IncomingMessage deprecation code (Guy Bedford) #36917
  • [5ae5ca90ef] - (SEMVER-MAJOR) doc: add http.IncomingMessage#connection (Pranshu Srivastava) #33768
  • [83d6e63aee] - (SEMVER-MAJOR) events: change EventTarget handler exception behavior (Nitzan Uziely) #37237
  • [9948036ee0] - (SEMVER-MAJOR) fs: remove permissive rmdir recursive (Antoine du Hamel) #37216
  • [d4693ff430] - (SEMVER-MAJOR) fs: add validation for fd and path (Dylan Elliott) #35187
  • [0ddd75bcd8] - (SEMVER-MAJOR) fs: runtime deprecate rmdir recursive option (Antoine du Hamel) #37302
  • [da217d0773] - (SEMVER-MAJOR) fs: fix flag and mode validation (James M Snell) #37480
  • [2ef9a76ece] - (SEMVER-MAJOR) http: use objects with null prototype in Agent (Michaël Zasso) #36409
  • [25e30005b8] - (SEMVER-MAJOR) lib: runtime deprecate access to process.binding('http_parser') (James M Snell) #37813
  • [8bb4e048af] - (SEMVER-MAJOR) lib: runtime deprecate access to process.binding('url') (James M Snell) #37799
  • [fe73e4d578] - (SEMVER-MAJOR) lib: make process.binding('util') return only type checkers (Anna Henningsen) #37819
  • [3bee6d8aad] - (SEMVER-MAJOR) lib: runtime deprecate access to process.binding('crypto') (James M Snell) #37790
  • [ac00df112e] - (SEMVER-MAJOR) lib: runtime deprecate access to process.binding('signal_wrap') (James M Snell) #37800
  • [ae595d76e3] - (SEMVER-MAJOR) lib: runtime deprecate access to process.binding('v8') (James M Snell) #37789
  • [104dac79cc] - (SEMVER-MAJOR) lib: aggregate errors to avoid error swallowing (Antoine du Hamel) #37460
  • [8d78d9ef27] - (SEMVER-MAJOR) lib: load v8_prof_processor dependencies as ESM (Michaël Zasso) #37587
  • [1468c9ff7c] - (SEMVER-MAJOR) lib: runtime deprecate access to process.binding('async_wrap') (James M Snell) #37576
  • [295e766c27] - (SEMVER-MAJOR) lib: remove usage of url.parse (raisinten) #36853
  • [cb3020d824] - (SEMVER-MAJOR) lib: add error handling for input stream (rexagod) #31603
  • [15164cebce] - (SEMVER-MAJOR) lib,src: update cluster to use Parent (Michael Dawson) #36478
  • [3cc9aec988] - (SEMVER-MAJOR) module: runtime deprecate subpath folder mappings (Antoine du Hamel) #37215
  • [9fab73c73b] - (SEMVER-MAJOR) module: runtime deprecate "main" index and extension lookups (Antoine du Hamel) #37206
  • [76a073b67e] - (SEMVER-MAJOR) module: runtime deprecate invalid package.json main entries (Antoine du Hamel) #37204
  • [674614b3f5] - (SEMVER-MAJOR) module: remove module.createRequireFromPath (Antoine du Hamel) #37201
  • [aecd5ebf49] - (SEMVER-MAJOR) module: only set cache when finding module succeeds (Yongsheng Zhang) #36642
  • [f0bf373176] - (SEMVER-MAJOR) perf_hooks: make performance a global (James M Snell) #37970
  • [f3eb224c83] - (SEMVER-MAJOR) perf_hooks: complete overhaul of the implementation (James M Snell) #37136
  • [f1753d4c76] - (SEMVER-MAJOR) process: disallow adding options to process.allowedNodeEnvironmentFlags (Antoine du Hamel) #36660
  • [96f3977ded] - (SEMVER-MAJOR) process: runtime deprecate changing process.config (James M Snell) #36902
  • [45dbcbef90] - (SEMVER-MAJOR) readline: cursorTo throw error on NaN (Zijian Liu) #36379
  • [8e8dea36cc] - (SEMVER-MAJOR) src: use non-deprecated GetCreationContext from V8 (Michaël Zasso) #37587
  • [b1c1c4695c] - (SEMVER-MAJOR) src: remove V8_FT_ADAPTOR for V8 update (Colin Ihrig) #37587
  • [8f5cce6862] - (SEMVER-MAJOR) src: use non-deprecated V8 module APIs (Michaël Zasso) #37587
  • [497f6ca5b4] - (SEMVER-MAJOR) src: update NODE_MODULE_VERSION to 93 (Michaël Zasso) #37587
  • [001dc16cf1] - (SEMVER-MAJOR) src: use non-deprecated V8 module and script APIs (Michaël Zasso) #37330
  • [47a90d9f37] - (SEMVER-MAJOR) src: update NODE_MODULE_VERSION to 92 (Michaël Zasso) #37330
  • [5259d17309] - (SEMVER-MAJOR) src: update NODE_MODULE_VERSION to 91 (Michaël Zasso) #36139
  • [bf79987433] - (SEMVER-MAJOR) src: mark internally exported functions as explicitly internal (Tyler Ang-Wanek) #37000
  • [1fe571aa0c] - (SEMVER-MAJOR) src: inline AsyncCleanupHookHandle in headers (Tyler Ang-Wanek) #37000
  • [6f9cbcf6a6] - (SEMVER-MAJOR) src: fix v8 api deprecation (Jiawen Geng) #35700
  • [9d4d55bd94] - (SEMVER-MAJOR) src: update NODE_MODULE_VERSION to 90 (Michaël Zasso) #35700
  • [dfc288e7fd] - (SEMVER-MAJOR) src: clean up embedder API (Anna Henningsen) #35897
  • [fa3997d75a] - (SEMVER-MAJOR) test: mark test-return-on-exit as flaky (Michaël Zasso) #36139
  • [896ae96a15] - (SEMVER-MAJOR) test: mark WASI's test-return-on-exit as flaky (Colin Ihrig) #36139
  • [9843361c07] - (SEMVER-MAJOR) tools: update V8 gypfiles for 9.0 (Michaël Zasso) #37587
  • [017661768a] - (SEMVER-MAJOR) tools: update V8 gypfiles for 8.9 (Michaël Zasso) #37330
  • [79da253473] - (SEMVER-MAJOR) tools: update V8 gypfiles for 8.8 (Michaël Zasso) #36139
  • [770d9e2542] - (SEMVER-MAJOR) tools: update V8 gypfiles for 8.7 (Michaël Zasso) #35700
  • [65e8864fa3] - (SEMVER-MAJOR) worker: send correct error status for worker init (Yash Ladha) #36242

Semver-Minor Commits

  • [944a956087] - (SEMVER-MINOR) assert: graduate assert.match and assert.doesNotMatch (James M Snell) #38111
  • [6a1986d50a] - (SEMVER-MINOR) deps: update llhttp to 5.1.0 (Fedor Indutny) #38146
  • [069b5df4f6] - (SEMVER-MINOR) module: add support for node:‑prefixed require(…) calls (ExE Boss) #37246
  • [b803bca4fa] - (SEMVER-MINOR) perf_hooks: add histogram option to timerify (James M Snell) #37475
  • [95391fe689] - (SEMVER-MINOR) repl: add auto‑completion for node:‑prefixed require(…) calls (ExE Boss) #37246
  • [15b8e6b1c4] - (SEMVER-MINOR) timers: graduate awaitable timers and improve docs (James M Snell) #38112

Semver-Patch Commits

@nodejs-github-bot

This comment has been hidden.

@BethGriggs BethGriggs added the wip label Mar 10, 2021
@BethGriggs
Copy link
Member Author

@BethGriggs BethGriggs commented Mar 10, 2021

Converting out of draft so actions runs are automatic.

@BethGriggs BethGriggs marked this pull request as ready for review Mar 10, 2021
@targos
Copy link
Member

@targos targos commented Mar 10, 2021

Just noting that to finish the preparation of V8 for 16.0.0, we need to land #37570 and #37587 (I'll update the latter and ask for an early merge later this week)

BethGriggs added a commit that referenced this pull request Mar 11, 2021
Notable changes:

* TBD

PR-URL: #37678
@BethGriggs BethGriggs force-pushed the v16.0.0-proposal branch from 3ff62ad to c7c08e1 Mar 11, 2021
@targos targos mentioned this pull request Mar 12, 2021
BethGriggs added a commit that referenced this pull request Mar 19, 2021
Notable changes:

* TBD

PR-URL: #37678
@BethGriggs BethGriggs force-pushed the v16.0.0-proposal branch from c7c08e1 to f74da0a Mar 19, 2021
@targos
Copy link
Member

@targos targos commented Mar 20, 2021

Analysis of (some of) the citgm results: nodejs/citgm#852 (comment)

@ExE-Boss
Copy link
Contributor

@ExE-Boss ExE-Boss commented Mar 24, 2021

#37246 (069b5df and 95391fe) should probably also be listed as part of “Notable Changes”.

@mcollina
Copy link
Member

@mcollina mcollina commented Mar 27, 2021

You might want to wait for #37937 as e2f5bb7 might need to be amended or reverted.

BethGriggs added a commit that referenced this pull request Mar 27, 2021
Notable changes:

* TBD

PR-URL: #37678
@BethGriggs BethGriggs force-pushed the v16.0.0-proposal branch from f74da0a to 3813f89 Mar 27, 2021
@BethGriggs
Copy link
Member Author

@BethGriggs BethGriggs commented Mar 27, 2021

Thanks @ExE-Boss - I've labelled #37246 notable-change and pulled it into the release/changelog.

& thanks @mcollina, I will try and keep track of that one over the next week and revert if necessary.

@BethGriggs
Copy link
Member Author

@BethGriggs BethGriggs commented Mar 27, 2021

parallel/test-release-npm is failing due to \n being printed to stderr. The test only runs on release builds, so we missed this going in.

So far I have tracked it down to npm/cli@41facf6 which came in via npm@7.7.0. Specifically, we're hitting a cb() is never called error. It is being masked by the npm logs being silenced, but a \n is still output to stderr by the error handler.

/cc @nodejs/npm (although potentially already on your radar from chatting with @ruyadorno)

ruyadorno added a commit to npm/cli that referenced this pull request Mar 29, 2021
Starting in v7.7.0 running `npm` (no args) is printing an empty newline
to stderr.

This fixes that by correctly exiting via errorHandler and avoiding
hitting the cb() never called error and adds a test to make sure we
avoid that regression moving forward.

Fixes: nodejs/node#37678 (comment)

Co-authored-by: Gar <gar+gh@danger.computer>
ruyadorno added a commit to npm/cli that referenced this pull request Mar 29, 2021
Starting in v7.7.0 running `npm` (no args) is printing an empty newline
to stderr.

This fixes that by correctly exiting via errorHandler and avoiding
hitting the cb() never called error and adds a test to make sure we
avoid that regression moving forward.

Fixes: nodejs/node#37678 (comment)

Co-authored-by: Gar <gar+gh@danger.computer>
ruyadorno added a commit to npm/cli that referenced this pull request Mar 29, 2021
Starting in v7.7.0 running `npm` (no args) is printing an empty newline
to stderr.

This fixes that by correctly exiting via errorHandler and avoiding
hitting the cb() never called error and adds a test to make sure we
avoid that regression moving forward.

Fixes: nodejs/node#37678 (comment)

Co-authored-by: Gar <gar+gh@danger.computer>
ruyadorno added a commit to npm/cli that referenced this pull request Mar 29, 2021
Starting in v7.7.0 running `npm` (no args) is printing an empty newline
to stderr.

This fixes that by correctly exiting via errorHandler and avoiding
hitting the cb() never called error and adds a test to make sure we
avoid that regression moving forward.

Fixes: nodejs/node#37678 (comment)

Co-authored-by: Gar <gar+gh@danger.computer>
ruyadorno added a commit to npm/cli that referenced this pull request Mar 29, 2021
Starting in v7.7.0 running `npm` (no args) is printing an empty newline
to stderr.

This fixes that by correctly exiting via errorHandler and avoiding
hitting the cb() never called error and adds a test to make sure we
avoid that regression moving forward.

Fixes: nodejs/node#37678 (comment)

Co-authored-by: Gar <gar+gh@danger.computer>
ruyadorno added a commit to npm/cli that referenced this pull request Mar 29, 2021
Starting in v7.7.0 running `npm` (no args) is printing an empty newline
to stderr.

This fixes that by correctly exiting via errorHandler and avoiding
hitting the cb() never called error and adds a test to make sure we
avoid that regression moving forward.

Fixes: nodejs/node#37678 (comment)

Co-authored-by: Gar <gar+gh@danger.computer>
@BethGriggs BethGriggs reopened this Mar 29, 2021
@saper saper mentioned this pull request Mar 29, 2021
0 of 4 tasks complete
BethGriggs added a commit that referenced this pull request Mar 30, 2021
Notable changes:

* TBD

PR-URL: #37678
@BethGriggs BethGriggs force-pushed the v16.0.0-proposal branch from 3813f89 to 9644d7a Mar 30, 2021
@nodejs-github-bot

This comment has been hidden.

@mcollina
Copy link
Member

@mcollina mcollina commented Mar 31, 2021

@BethGriggs can you pull in 16920db? Also regenerate the notable changes on top as one was reverted.

@targos targos added the release label Apr 3, 2021
BethGriggs added a commit that referenced this pull request Apr 6, 2021
Notable changes:

* TBD

PR-URL: #37678
@BethGriggs BethGriggs force-pushed the v16.0.0-proposal branch from 9644d7a to 3bc20dc Apr 6, 2021
@BethGriggs
Copy link
Member Author

@BethGriggs BethGriggs commented Apr 6, 2021

I've updated the proposal for rc.2. I hope for the commits for v16.0.0 to be mostly frozen on ~13th April. This gives us some baking time before the release and time to finalize the changelog/release announcement.

@nodejs/tsc the following majors landed with < 4 weeks to go. Please let me know if there are any objections to any of these landing in v16.0.0:

  • [f0bf373176] - (SEMVER-MAJOR) perf_hooks: make performance a global (James M Snell) #37970
  • [25e30005b8] - (SEMVER-MAJOR) lib: runtime deprecate access to process.binding('http_parser') (James M Snell) #37813
  • [8bb4e048af] - (SEMVER-MAJOR) lib: runtime deprecate access to process.binding('url') (James M Snell) #37799
  • [fe73e4d578] - (SEMVER-MAJOR) lib: make process.binding('util') return only type checkers (Anna Henningsen) #37819
  • [290c158018] - (SEMVER-MAJOR) doc: update minimum supported Xcode to 11 (Michaël Zasso) #37872
  • [1ff2918d80] - (SEMVER-MAJOR) doc: update minimum supported GCC to 8.3 (Michaël Zasso) #37871
  • [d1e2184c8e] - (SEMVER-MAJOR) buffer: expose btoa and atob as globals (James M Snell) #37786

(I'd appreciate 👀, or something, to indicate that you've seen the list and have no objections).

@nodejs-github-bot

This comment has been hidden.

BethGriggs added a commit that referenced this pull request Apr 10, 2021
Notable changes:

* TBD

PR-URL: #37678
@BethGriggs BethGriggs force-pushed the v16.0.0-proposal branch from 3bc20dc to 1d01c78 Apr 10, 2021
@Trott
Copy link
Member

@Trott Trott commented Apr 10, 2021

  • [d1e2184c8e] - (SEMVER-MAJOR) buffer: expose btoa and atob as globals (James M Snell) #37786

I'm wondering if we want to fast-track in a change to make these enumerable per #37786 (review) unless there is some technical reason we can't/shouldn't do that? @jasnell

Notable changes:

* TBD

PR-URL: #37678
@BethGriggs BethGriggs force-pushed the v16.0.0-proposal branch from 1d01c78 to e3fe306 Apr 12, 2021
* [[`324a6c235a`](https://github.com/nodejs/node/commit/324a6c235a)] - **(SEMVER-MAJOR)** **async_hooks**: add thisArg to AsyncResource.bind (James M Snell) [#36782](https://github.com/nodejs/node/pull/36782)
* [[`d1e2184c8e`](https://github.com/nodejs/node/commit/d1e2184c8e)] - **(SEMVER-MAJOR)** **buffer**: expose btoa and atob as globals (James M Snell) [#37786](https://github.com/nodejs/node/pull/37786)
* [[`1d8c022544`](https://github.com/nodejs/node/commit/1d8c022544)] - **(SEMVER-MAJOR)** **build**: update Makefile to support fat binary (Ash Cripps) [#37861](https://github.com/nodejs/node/pull/37861)
* [[`a572a4e34e`](https://github.com/nodejs/node/commit/a572a4e34e)] - **(SEMVER-MAJOR)** **build**: reset embedder string to "-node.0" (Michaël Zasso) [#37587](https://github.com/nodejs/node/pull/37587)

This comment has been minimized.

@BethGriggs

BethGriggs Apr 12, 2021
Author Member

@targos, do you think it makes sense to remove semver-major indicator from some of the commits in #37587 such as this one? And potentially do the same for commits related to #37330 too?

This comment has been minimized.

@targos

targos Apr 14, 2021
Member

Yes, I'll prepare a patch for the changelog once you've finalized the commit list. Ping me again when it's ready, please.

@BethGriggs
Copy link
Member Author

@BethGriggs BethGriggs commented Apr 14, 2021

FYI, I plan to update the proposal and produce the last rc later today. If there are any PRs that are yet to land on master that I should wait for, please let me know.

(Already keeping track of #38227 and the Python 2/3 related PRs.)

@mcollina
Copy link
Member

@mcollina mcollina commented Apr 14, 2021

There are #38099 and #37931.

If we would like to merge #37931 in v16 altogether cc @nodejs/tsc.

@mcollina
Copy link
Member

@mcollina mcollina commented Apr 14, 2021

#37966 should be included as well.

@targos
Copy link
Member

@targos targos commented Apr 14, 2021

#38218 should be included, and ideally #38237 too (it's the last patch to V8 before Chrome 90 was released)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
X Tutup