X Tutup
The Wayback Machine - https://web.archive.org/web/20220611135606/https://github.com/python/typeshed/pull/5501
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document _typeshed #5501

Merged
merged 3 commits into from May 19, 2021
Merged

Document _typeshed #5501

merged 3 commits into from May 19, 2021

Conversation

srittau
Copy link
Collaborator

@srittau srittau commented May 19, 2021

Closes: #5486

I have marked types I personally consider stable as such, but I'm open to changes.

@github-actions

This comment has been minimized.

1 similar comment
@github-actions

This comment has been minimized.

stdlib/_typeshed/tkinter.pyi Outdated Show resolved Hide resolved
@Akuli
Copy link
Collaborator

@Akuli Akuli commented May 19, 2021

If _typeshed/foo.pyi defines _Bar, then can we do from _typeshed.foo import _Bar? This might be a more standard way to mark stable/unstable things than a # stable comment.

@srittau
Copy link
Collaborator Author

@srittau srittau commented May 19, 2021

_typeshed is still mostly for internal use. I'd also expect types to become stable after they've proven themselves in _typeshed and I don't want to do a big search/replace through all of typeshed when we mark a type as stable. This would also make _typeshed more unstable, because it changes more often.

@srittau
Copy link
Collaborator Author

@srittau srittau commented May 19, 2021

The CI failure is unrelated and likely caused by python/mypy#10507.

@github-actions
Copy link
Contributor

@github-actions github-actions bot commented May 19, 2021

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

@Akuli Akuli merged commit 21e647a into python:master May 19, 2021
40 of 41 checks passed
@srittau srittau deleted the document-typeshed branch Mar 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
X Tutup