Don’t try to create auto import provider when host program doesn’t exist #45126
+7
−3
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Fixes #44849
Looking at the error stack and the code path leading to the crash, I’m not sure how to produce this, but one user claimed that they had some reason to believe it was triggered by an unofficial Vue extension, and indeed both VS Code reports list that extension, but I couldn’t trigger it myself. At any rate, the auto import provider can be loaded lazily, and if someone somehow requests it before having a program, there’s no reason to crash; we can just return undefined.