X Tutup
The Wayback Machine - https://web.archive.org/web/20220203020606/https://github.com/python/cpython/pull/27177
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-40897:Give priority to using the current class constructor in inspect.signature #27177

Merged
merged 2 commits into from Jul 16, 2021
Merged

bpo-40897:Give priority to using the current class constructor in inspect.signature #27177

merged 2 commits into from Jul 16, 2021

Conversation

@hongweipeng
Copy link
Contributor

@hongweipeng hongweipeng commented Jul 16, 2021 •
edited by bedevere-bot

https://bugs.python.org/issue40897
@mauvilsa
Copy link

@mauvilsa mauvilsa commented Jul 16, 2021

@hongweipeng could you please comment here or in https://bugs.python.org/issue40897 if this fixes what I commented about the datetime classes. If it does fix it, would it be okay to add a unit test which checks getting the signature of e.g. datetime.timedelta?

@ambv
Copy link
Contributor

@ambv ambv commented Jul 16, 2021

@mauvilsa, as you rightfully noticed yourself, this is a separate issue. Thanks for creating BPO-44618, we will deal with this separately.

@ambv
Copy link
Contributor

@ambv ambv commented Jul 16, 2021

Address sanitizer failure unrelated.

@ambv ambv merged commit 6aab5f9 into python:main Jul 16, 2021
12 of 13 checks passed
@bedevere-bot
Copy link

@bedevere-bot bedevere-bot commented Jul 16, 2021

@ambv: Please replace # with GH- in the commit message next time. Thanks!

@miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Jul 16, 2021

Thanks @hongweipeng for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Jul 16, 2021

Thanks @hongweipeng for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Jul 16, 2021

Sorry, @hongweipeng and @ambv, I could not cleanly backport this to 3.9 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 6aab5f9bf303a8e4cd8377fabcdcb499e0541f9a 3.9

@miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Jul 16, 2021

Sorry @hongweipeng and @ambv, I had trouble checking out the 3.10 backport branch.
Please backport using cherry_picker on command line.
cherry_picker 6aab5f9bf303a8e4cd8377fabcdcb499e0541f9a 3.10

@sthagen sthagen mentioned this pull request Jul 16, 2021
Merged
@miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Jul 16, 2021

Thanks @hongweipeng for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Jul 16, 2021

Thanks @hongweipeng for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖

@bedevere-bot
Copy link

@bedevere-bot bedevere-bot commented Jul 16, 2021

GH-27189 is a backport of this pull request to the 3.10 branch.

@miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Jul 16, 2021

Sorry, @hongweipeng and @ambv, I could not cleanly backport this to 3.9 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 6aab5f9bf303a8e4cd8377fabcdcb499e0541f9a 3.9

miss-islington added a commit to miss-islington/cpython that referenced this issue Jul 16, 2021
@hongweipeng @miss-islington
bpo-40897:Give priority to using the current class constructor in `in…
007cf76 
…spect.signature` (pythonGH-27177)

Co-authored-by: Łukasz Langa <lukasz@langa.pl>
(cherry picked from commit 6aab5f9)

Co-authored-by: Weipeng Hong <hongweichen8888@sina.com>
ambv pushed a commit that referenced this issue Jul 16, 2021
@hongweipeng @miss-islington
bpo-40897:Give priority to using the current class constructor in `in…
948e39a 
…spect.signature` (GH-27177) (#27189)

Co-authored-by: Łukasz Langa <lukasz@langa.pl>
(cherry picked from commit 6aab5f9)

Co-authored-by: Weipeng Hong <hongweichen8888@sina.com>
@ambv ambv mentioned this pull request Jul 16, 2021
Merged
@miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Jul 17, 2021

Thanks @hongweipeng for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖

@bedevere-bot
Copy link

@bedevere-bot bedevere-bot commented Jul 17, 2021

GH-27209 is a backport of this pull request to the 3.9 branch.

miss-islington added a commit to miss-islington/cpython that referenced this issue Jul 17, 2021
@hongweipeng @miss-islington
bpo-40897:Give priority to using the current class constructor in `in…
e1e5a3b 
…spect.signature` (pythonGH-27177)

Co-authored-by: Łukasz Langa <lukasz@langa.pl>
(cherry picked from commit 6aab5f9)

Co-authored-by: Weipeng Hong <hongweichen8888@sina.com>
ambv pushed a commit that referenced this issue Jul 17, 2021
@hongweipeng @miss-islington
bpo-40897:Give priority to using the current class constructor in `in…
df7c629 
…spect.signature` (GH-27177) (GH-27209)

Co-authored-by: Łukasz Langa <lukasz@langa.pl>
(cherry picked from commit 6aab5f9)

Co-authored-by: Weipeng Hong <hongweichen8888@sina.com>
@pablogsal pablogsal mentioned this pull request Jul 18, 2021
Closed
JuniorJPDJ added a commit to JuniorJPDJ/cpython that referenced this issue Aug 12, 2021
@hongweipeng @ambv @JuniorJPDJ
bpo-40897:Give priority to using the current class constructor in `in…
28b2955 
…spect.signature` (python#27177)

Co-authored-by: Łukasz Langa <lukasz@langa.pl>
@hongweipeng hongweipeng deleted the inspect-signature-use-current-class-first branch Dec 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ambv ambv

Labels
CLA signed
Projects
None yet
Milestone
No milestone
6 participants
@hongweipeng @mauvilsa @ambv @bedevere-bot @miss-islington @the-knights-who-say-ni
X Tutup