X Tutup
The Wayback Machine - https://web.archive.org/web/20220206170114/https://github.com/freeCodeCamp/freeCodeCamp/pull/42438
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: remove eslint-plugin-prettier for prettier #42438

Merged
merged 5 commits into from Oct 6, 2021
Merged

feat: remove eslint-plugin-prettier for prettier #42438

merged 5 commits into from Oct 6, 2021

Conversation

@ojeytonwilliams
Copy link
Contributor

@ojeytonwilliams ojeytonwilliams commented Jun 11, 2021

The idea is to remove two sources of noise. Firstly the annoying lint warnings when all that needs to change is
formatting and secondly the messy diffs that a format change causes.
@ojeytonwilliams ojeytonwilliams requested review from as code owners Jun 11, 2021
@gitpod-io
Copy link

@gitpod-io gitpod-io bot commented Jun 11, 2021

@github-actions

This comment has been hidden.

Sign in to view
@ojeytonwilliams ojeytonwilliams marked this pull request as draft Jun 11, 2021
@github-actions

This comment has been hidden.

Sign in to view
@ojeytonwilliams ojeytonwilliams marked this pull request as ready for review Jun 11, 2021
@nhcarrigan nhcarrigan mentioned this pull request Sep 23, 2021
Merged
4 tasks
@ojeytonwilliams
feat: remove eslint-plugin-prettier for prettier
dbd28d8 
This removes the annoying lint warnings when all that needs to change is
formatting
@ojeytonwilliams
fix: use .js lint-staged config to ignore properly
18cf7d2
@ojeytonwilliams
fix: lint everything if a lot of files are changed
b537eb7 
It's faster than making lots of individual linter calls
@ojeytonwilliams
chore: apply prettier
6091ed6
ShaunSHamilton
ShaunSHamilton approved these changes Oct 6, 2021
View changes
Copy link
Contributor

@ShaunSHamilton ShaunSHamilton left a comment

LGTM 👍

@ShaunSHamilton ShaunSHamilton enabled auto-merge (squash) Oct 6, 2021
@ojeytonwilliams ojeytonwilliams mentioned this pull request Oct 6, 2021
Merged
4 tasks
raisedadead
raisedadead approved these changes Oct 6, 2021
View changes
Copy link
Member

@raisedadead raisedadead left a comment

Sorry, this took a while to get in. Nice work on cleaning up things as always @ojeytonwilliams

@ShaunSHamilton ShaunSHamilton merged commit c8d7f0a into freeCodeCamp:main Oct 6, 2021
13 checks passed
@ojeytonwilliams ojeytonwilliams deleted the fix/prettier branch Oct 6, 2021
@ojeytonwilliams
Copy link
Contributor Author

@ojeytonwilliams ojeytonwilliams commented Oct 6, 2021

No problem @raisedadead I know it's a pain to review things like this.

@nhcarrigan nhcarrigan mentioned this pull request Oct 7, 2021
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nhcarrigan nhcarrigan

@raisedadead raisedadead

@ShaunSHamilton ShaunSHamilton

Assignees
No one assigned
Labels
platform: api platform: client scope: docs scope: i18n scope: tools/scripts status: waiting review
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet
4 participants
@ojeytonwilliams @raisedadead @ShaunSHamilton @nhcarrigan
X Tutup