X Tutup
The Wayback Machine - https://web.archive.org/web/20260401183455/https://github.com/python/devguide/pull/677
Skip to content

Clarify stale label#677

Closed
skirpichev wants to merge 2 commits intopython:mainfrom
skirpichev:stale
Closed

Clarify stale label#677
skirpichev wants to merge 2 commits intopython:mainfrom
skirpichev:stale

Conversation

@skirpichev
Copy link
Copy Markdown
Member

It seems, most recent "stale" issues got that label just because were unreviewed. Trying to document this...

@Mariatta
Copy link
Copy Markdown
Member

The stale label is nowadays added by stale GitHub Actions. It's not just the "unreviewed", but anything that hasn't had any activity after 30 days. https://github.com/actions/stale

@skirpichev
Copy link
Copy Markdown
Member Author

Are you suggesting to simplify the label description even more?

Something like: Used for PRs that hasn't had any activity in a long period of time. This label helps core developers quickly identify PRs that are candidates for closure, for review or require a ping to the author.

Copy link
Copy Markdown
Member

@hugovk hugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you suggesting to simplify the label description even more?

Something like: Used for PRs that hasn't had any activity in a long period of time. This label helps core developers quickly identify PRs that are candidates for closure, for review or require a ping to the author.

That sounds good to me, it includes the "candidate for review" possibility too.

Except also include this grammar fix and let's explicitly mention the 30 days:

-Used for PRs that hasn't had any activity in a long period of time.
+Used for PRs that haven't had any activity in 30 days.

@skirpichev skirpichev closed this Feb 10, 2022
@skirpichev skirpichev deleted the stale branch February 10, 2022 04:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

X Tutup