Development test failure #2180
Open
Development test failure #2180
Conversation
This was referenced Apr 13, 2021
| //Assertions fail for functional reasons | ||
| Assertions.assertEquals(toUpperCase("abc"), "abc", "The strings are not equals"); | ||
|
|
||
| Assertions.assertNotEquals(toUpperCase("abc"), "abc", "The strings are not equals"); |
nishantc1527
Apr 18, 2021
Contributor
I think it would be useful if there would be a test something like:
Assertions.assertEquals(toUpperCase("abc"), "ABC", "The strings are equal");
Just to check if the string is correctly capitalized.
| @@ -8,8 +8,8 @@ | |||
| @Test | |||
| void testUpper() { | |||
| Assertions.assertEquals(toUpperCase("abc"), ("abc").toUpperCase(), "The strings are equals"); | |||
nishantc1527
Apr 18, 2021
Contributor
Instead of "The strings are equals" I think it should be "The strings are equal"
|
I need some more details why the test did not pass. |
|
I'm also wondering why the tests don't work. I'm looking at it right now. |
| Assertions.assertEquals(toUpperCase("abc"), ("abc").toUpperCase(), "The strings are equals"); | ||
| //Assertions fail for functional reasons | ||
| Assertions.assertEquals(toUpperCase("abc"), "abc", "The strings are not equals"); | ||
| Assertions.assertEquals( "ABC",toUpperCase("abc"), "The strings are equal"); |
nishantc1527
Apr 20, 2021
Contributor
I guess you can revert this assertion and we can figure it out later.
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Describe your change:
References
Correct the test in UpperTest.java and delete comment. Test-cases are working now.
Checklist:
Fixes: #{$ISSUE_NO}.