X Tutup
The Wayback Machine - https://web.archive.org/web/20210414081333/https://github.com/microsoft/TypeScript/pull/40909
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix object.assign first param constraint #40909

Open
wants to merge 5 commits into
base: master
from

Conversation

@sandersn
Copy link
Member

@sandersn sandersn commented Oct 2, 2020

Fixes #35621
Follow-up to #36768

TrejGun and others added 2 commits Feb 13, 2020
@sandersn
Copy link
Member Author

@sandersn sandersn commented Oct 2, 2020

@typescript-bot user test this

@typescript-bot
Copy link
Collaborator

@typescript-bot typescript-bot commented Oct 2, 2020

Heya @sandersn, I've started to run the parallelized community code test suite on this PR at f6f2baa. You can monitor the build here.

@sandersn
Copy link
Member Author

@sandersn sandersn commented Oct 2, 2020

@typescript-bot
Copy link
Collaborator

@typescript-bot typescript-bot commented Oct 2, 2020

Heya @sandersn, I've started to run the parallelized Definitely Typed test suite on this PR at f6f2baa. You can monitor the build here.

@sandersn
Copy link
Member Author

@sandersn sandersn commented Oct 2, 2020

@typescript-bot test this

@typescript-bot
Copy link
Collaborator

@typescript-bot typescript-bot commented Oct 2, 2020

Heya @sandersn, I've started to run the extended test suite on this PR at f6f2baa. You can monitor the build here.

@typescript-bot
Copy link
Collaborator

@typescript-bot typescript-bot commented Oct 2, 2020

The user suite test run you requested has finished and failed. I've opened a PR with the baseline diff from master.

@sandersn
Copy link
Member Author

@sandersn sandersn commented Oct 4, 2020

@typescript-bot user test this

@typescript-bot
Copy link
Collaborator

@typescript-bot typescript-bot commented Oct 4, 2020

Heya @sandersn, I've started to run the parallelized community code test suite on this PR at f6f2baa. You can monitor the build here.

@sandersn sandersn added this to Not started in PR Backlog Oct 9, 2020
@sandersn sandersn moved this from Not started to Needs review in PR Backlog Oct 9, 2020
@sandersn
Copy link
Member Author

@sandersn sandersn commented Apr 6, 2021

@typescript-bot user test this

@typescript-bot
Copy link
Collaborator

@typescript-bot typescript-bot commented Apr 6, 2021

Heya @sandersn, I've started to run the parallelized community code test suite on this PR at b1350dd. You can monitor the build here.

@sandersn
Copy link
Member Author

@sandersn sandersn commented Apr 6, 2021

@typescript-bot
Copy link
Collaborator

@typescript-bot typescript-bot commented Apr 6, 2021

Heya @sandersn, I've started to run the parallelized Definitely Typed test suite on this PR at b1350dd. You can monitor the build here.

@sandersn
Copy link
Member Author

@sandersn sandersn commented Apr 6, 2021

DT is clean.

@sandersn
Copy link
Member Author

@sandersn sandersn commented Apr 6, 2021

One more time:
@typescript-bot user test this

@typescript-bot
Copy link
Collaborator

@typescript-bot typescript-bot commented Apr 6, 2021

Heya @sandersn, I've started to run the parallelized community code test suite on this PR at 2c3932c. You can monitor the build here.

@sandersn
Copy link
Member Author

@sandersn sandersn commented Apr 7, 2021

User tests are clean.

@sandersn sandersn requested review from weswigham and orta Apr 7, 2021
@sandersn
Copy link
Member Author

@sandersn sandersn commented Apr 7, 2021

I'm not going to put this into 4.3 since it's a lib change.

PR Backlog automation moved this from Needs review to Needs merge Apr 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
PR Backlog
  
Needs merge
Linked issues

Successfully merging this pull request may close these issues.

4 participants
X Tutup