Create dev/ci.yaml #79396
Create dev/ci.yaml #79396
Conversation
| @@ -8,6 +8,7 @@ | |||
|
|
|||
| /CODEOWNERS @jmagman | |||
| /dev/ci/ @christopherfujino | |||
| /dev/ci.yaml @caseyhillers | |||
christopherfujino
Mar 30, 2021
Contributor
can you place this as /.ci.yaml? the goal being easier discoverability by developers (this is also parity with what we had/have with cirrus)
CaseyHillers
Mar 30, 2021
Author
Contributor
Done. This is the best location as Cocoon doesn't need to track for every repo where the config exists
christopherfujino
Mar 30, 2021
Contributor
yeah, in my single recipe doc i specified that the recipe would always look in the same place for the file
| @@ -0,0 +1,32 @@ | |||
| # Describes the targets run in continuous integration environment. | |||
christopherfujino
Mar 30, 2021
Contributor
- does this need a license comment?
- I'd prefer a link to a doc in the cocoon source tree (or anywhere, as long as there is only one). this schema is bound to change :)
CaseyHillers
Mar 30, 2021
Author
Contributor
- I looked at cirrus and devicelab yaml files and didn't see license headers, so I didn't include one here
- That's a good point (make it easier to copy this config to other repos). For now, is it okay to leave this in and later this week I can add documentation in Cocoon on the configs?
| @@ -6,6 +6,7 @@ | |||
| # | |||
| # Use git ls-files '<pattern>' without a / prefix to see the list of matching files. | |||
|
|
|||
| /.ci.yaml @caseyhillers | |||
godofredoc
Mar 30, 2021
Contributor
Can we add a group rather than a person? if not possible can we add at least one more person?
CaseyHillers
Mar 30, 2021
Author
Contributor
I believe we can (support forum) but we'd need a Flutter infra team in the flutter organization.
Do you know who we should talk to about creating that team?
christopherfujino
Mar 31, 2021
Contributor
cc @kf6gpe regarding creating a team under the Flutter github org
CaseyHillers
Mar 31, 2021
Author
Contributor
For now, I added Chris since he'll be working on the single recipe builds in this file.
While we're at it, should we create subteams for the other teams as well?
jmagman
Apr 1, 2021
Member
I think you can put them in the same line.
/.ci.yaml @caseyhillers @christopherfujino| # Child targets can reuse artifacts from parent targets. | ||
| # * properties: Map<String, String> of properties to pass to recipe | ||
| enabled_branches: | ||
| - master |
godofredoc
Mar 30, 2021
Contributor
How will this work for builders that run only on a subset of branches?
CaseyHillers
Mar 30, 2021
Author
Contributor
I need to sync up with @christopherfujino on this more, but we may need to duplicate the enabled_branches property into the target so it can override what it runs on. As we look into. bringing up the scheduler for that use case we can revisit
CaseyHillers
Apr 1, 2021
Author
Contributor
We decided there will be these global values, but targets will be able to override what is globally set
|
LGTM |
fluttergithubbot
merged commit 8743f94
into
flutter:master
Bringup the Cocoon scheduler file to start bootstrapping the scheduler. To get started, it will schedule a linux analyze task and surface it in the dashboard.
Temporarily adding myself as codeowner until this available for prod use.
Issues
#76140
Tests
No tests added as this is a config file. Future work is to bring up presubmit check against this file.
Locally validate with the validation script in cocoon.
dart $COCOON/app_dart/bin/validate_scheduler_config.dart $FLUTTER/.ci.yamlPre-launch Checklist
///).