X Tutup
The Wayback Machine - https://web.archive.org/web/20201230164435/https://github.com/nodejs/node/pull/36696
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build, tools, win: check if python is a executable program #36696

Open
wants to merge 1 commit into
base: master
from

Conversation

@Himself65
Copy link
Member

@Himself65 Himself65 commented Dec 30, 2020

Fixes: #36694

After Windows 10 version 1903, placeholder files named "python.exe" and "python3.exe" appear, not executable programs, and open the MS Store when running without parameters.

Refs: https://devblogs.microsoft.com/python/python-in-the-windows-10-may-2019-update

before install python
image

after
image

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
@Himself65 Himself65 force-pushed the Himself65:20201231-fix-find_python branch from ef21ecb to 4446e9a Dec 30, 2020
After Windows 10 version 1903, placeholder files named "python.exe" and "python3.exe" appear, not executable programs, and open the MS Store when running without parameters.

Fixes: #36694
Refs: https://devblogs.microsoft.com/python/python-in-the-windows-10-may-2019-update
@Himself65 Himself65 changed the title build,win: check if python is a executable program build, tools, win: check if python is a executable program Dec 30, 2020
@Himself65 Himself65 force-pushed the Himself65:20201231-fix-find_python branch from 4446e9a to 4dfdb67 Dec 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants
You can’t perform that action at this time.
X Tutup