X Tutup
The Wayback Machine - https://web.archive.org/web/20210814031606/https://github.com/nodejs/node/pull/38129
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib: fix typo in lib/_tls_common.js #38129

Merged
merged 1 commit into from Apr 8, 2021
Merged

Conversation

@arkerone
Copy link
Contributor

@arkerone arkerone commented Apr 7, 2021

I found a typo : "byteLenth" -> "byteLength"

@aduh95
aduh95 approved these changes Apr 7, 2021
@aduh95
Copy link
Contributor

@aduh95 aduh95 commented Apr 7, 2021

There's no reason to make this one wait the 48 hours to land. Collaborators, please 👍🏻 to fast-track

@lpinca
lpinca approved these changes Apr 7, 2021
@nodejs-github-bot

This comment has been hidden.

@jasnell
jasnell approved these changes Apr 7, 2021
@nodejs-github-bot

This comment has been hidden.

@nodejs-github-bot

This comment has been hidden.

@cjihrig
cjihrig approved these changes Apr 8, 2021
`byteLenth` -> `byteLength`.

PR-URL: #38129
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@aduh95 aduh95 force-pushed the arkerone:fix/typo-tls-common branch from 000048f to b16e79e Apr 8, 2021
@aduh95
Copy link
Contributor

@aduh95 aduh95 commented Apr 8, 2021

Landed in b16e79e

@aduh95 aduh95 merged commit b16e79e into nodejs:master Apr 8, 2021
17 checks passed
17 checks passed
@github-actions
build-tarball
Details
@github-actions
build-windows
Details
@github-actions
coverage-linux
Details
@github-actions
coverage-windows
Details
@github-actions
lint-addon-docs
Details
@github-actions
build-docs
Details
@github-actions
test-asan
Details
@github-actions
test-linux
Details
@github-actions
test-macOS
Details
@github-actions
test-tarball-linux
Details
@github-actions
lint-cpp
Details
@github-actions
lint-md
Details
@github-actions
lint-js
Details
@github-actions
lint-py
Details
@github-actions
lint-sh
Details
@github-actions
lint-codeowners
Details
@github-actions
lint-pr-url
Details
@arkerone arkerone deleted the arkerone:fix/typo-tls-common branch Apr 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

10 participants
X Tutup