X Tutup
The Wayback Machine - https://web.archive.org/web/20210829091214/https://github.com/nodejs/node/pull/38124
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: remove unneeded m flag on regular expressions #38124

Merged
merged 1 commit into from Apr 9, 2021
Merged

Conversation

@Trott
Copy link
Member

@Trott Trott commented Apr 7, 2021

The m flag has no effect on regular expressions that don't match the
start or the end of a line.

@Trott Trott changed the title test: remove useless m flag on regular expressions test: remove unneeded m flag on regular expressions Apr 7, 2021
@Trott Trott force-pushed the Trott:useless-m branch from a24df34 to f83d0c1 Apr 7, 2021
@aduh95
aduh95 approved these changes Apr 7, 2021
@nodejs-github-bot
Copy link

@nodejs-github-bot nodejs-github-bot commented Apr 7, 2021

@lpinca
lpinca approved these changes Apr 7, 2021
@nodejs-github-bot
Copy link

@nodejs-github-bot nodejs-github-bot commented Apr 7, 2021

@jasnell
jasnell approved these changes Apr 7, 2021
@cjihrig
cjihrig approved these changes Apr 8, 2021
The m flag has no effect on regular expressions that don't match the
start or the end of a line.

PR-URL: #38124
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@Trott Trott force-pushed the Trott:useless-m branch from f83d0c1 to 7e516aa Apr 9, 2021
@Trott
Copy link
Member Author

@Trott Trott commented Apr 9, 2021

Landed in 7e516aa

@Trott Trott merged commit 7e516aa into nodejs:master Apr 9, 2021
16 checks passed
16 checks passed
@github-actions
build-tarball
Details
@github-actions
build-windows
Details
@github-actions
coverage-linux
Details
@github-actions
coverage-windows
Details
@github-actions
lint-addon-docs
Details
@github-actions
build-docs
Details
@github-actions
test-asan
Details
@github-actions
test-linux
Details
@github-actions
test-macOS
Details
@github-actions
lint-cpp
Details
@github-actions
lint-md
Details
@github-actions
lint-js
Details
@github-actions
lint-py
Details
@github-actions
lint-sh
Details
@github-actions
lint-codeowners
Details
@github-actions
lint-pr-url
Details
@Trott Trott deleted the Trott:useless-m branch Apr 9, 2021
targos added a commit that referenced this pull request May 1, 2021
The m flag has no effect on regular expressions that don't match the
start or the end of a line.

PR-URL: #38124
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@danielleadams danielleadams mentioned this pull request May 3, 2021
danielleadams added a commit that referenced this pull request May 8, 2021
The m flag has no effect on regular expressions that don't match the
start or the end of a line.

PR-URL: #38124
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

8 participants
X Tutup