X Tutup
The Wayback Machine - https://web.archive.org/web/20210813191656/https://github.com/nodejs/node/pull/38066
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: add parentheses to function and move reference #38066

Closed
wants to merge 1 commit into from

Conversation

@Trott
Copy link
Member

@Trott Trott commented Apr 4, 2021

Add parentheses as unref() is a function. Move it to the correct
lexically-sorted location in the reference list.

@targos
targos approved these changes Apr 4, 2021
@cjihrig
cjihrig approved these changes Apr 4, 2021
@lpinca
lpinca approved these changes Apr 4, 2021
Add parentheses as `unref()` is a function. Move it to the correct
lexically-sorted location in the reference list.

PR-URL: #38066
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@Trott Trott force-pushed the Trott:parens branch from 9a25764 to ab42ef3 Apr 6, 2021
@Trott
Copy link
Member Author

@Trott Trott commented Apr 6, 2021

Landed in ab42ef3

@Trott Trott closed this Apr 6, 2021
@Trott Trott deleted the Trott:parens branch Apr 6, 2021
targos added a commit that referenced this pull request May 1, 2021
Add parentheses as `unref()` is a function. Move it to the correct
lexically-sorted location in the reference list.

PR-URL: #38066
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@danielleadams danielleadams mentioned this pull request May 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

7 participants
X Tutup