test: fix test-vm-memleak for high baseline platforms #38062
Closed
Conversation
|
Cherry-picked this over to #34289. |
test-vm-memleak always fails on AIX in CI because the test checks that total memory consumption is less than 64 Mb, but AIX uses over 100 Mb just as a baseline. So instead, let's compare the memory consumption to the baseline and make sure it is within 32 Mb.
|
This could use some reviews. @nodejs/testing @nodejs/platform-aix @nodejs/process @nodejs/vm |
|
Landed in a0492ba |
jasnell
added a commit
that referenced
this pull request
Apr 6, 2021
test-vm-memleak always fails on AIX in CI because the test checks that total memory consumption is less than 64 Mb, but AIX uses over 100 Mb just as a baseline. So instead, let's compare the memory consumption to the baseline and make sure it is within 32 Mb. PR-URL: #38062 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Ash Cripps <acripps@redhat.com> Reviewed-By: Beth Griggs <bgriggs@redhat.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
test-vm-memleak always fails on AIX in CI because the test checks that
total memory consumption is less than 64 Mb, but AIX uses over 100 Mb
just as a baseline. So instead, let's compare the memory consumption to
the baseline and make sure it is within 32 Mb.